This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Move the sed in place edit flag outside the gcc_toolchain template #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids GN warnings in targets such as Wasm where this variable is never used.
zanderso
approved these changes
Jan 6, 2024
Member
|
Merging to try to get this roll unblocked. |
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jan 9, 2024
flutter/buildroot#804 flutter/buildroot#806 flutter/buildroot#808 flutter/buildroot#809 flutter/buildroot#810 Engine tests were already running on iOS 13. Part of flutter/flutter#140474 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids GN warnings in targets such as Wasm where this variable is never used.