This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Refactors the RBE build #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
mac-rbe
branch
2 times, most recently
from
2895459 to
1535c3f
Compare
jason-simmons
approved these changes
Jan 9, 2024
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Jan 9, 2024
This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the `use_rbe` flag as a custom var in the `.gclient` file. This PR also turns on RBE for Linux and macOS builds that do not produce artifacts. flutter/buildroot#807
zijiehe-google-com
pushed a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 9, 2024
This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the `use_rbe` flag as a custom var in the `.gclient` file. This PR also turns on RBE for Linux and macOS builds that do not produce artifacts. flutter/buildroot#807
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jan 9, 2024
Reverts #49416 Initiated by: zanderso This change reverts the following previous change: Original Description: This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the `use_rbe` flag as a custom var in the `.gclient` file. This PR also turns on RBE for Linux and macOS builds that do not produce artifacts. flutter/buildroot#807
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/buildroot changes to support flutter/engine#49416