RBE #758
RBE #758
Conversation
| enable_deps_cache=true | ||
| xattr_digest=user.fuchsia.rbe.digest.sha256 | ||
| server_address=unix:///tmp/reproxy.sock | ||
| log_dir=/tmp |
There was a problem hiding this comment.
Nit: can we use a dir based on timestamp?
There was a problem hiding this comment.
You tell me =) I just copied this from your doc.
There was a problem hiding this comment.
This file here is used for local build, and the dir should not be a problem.
I will make sure recipes to use a timestamp based dir when executed from CI/LED.
There was a problem hiding this comment.
Can you tell me how you plan to do that?
There was a problem hiding this comment.
One way we can do is have recipes read this cfg file and override the log_file value before starting the bootstrap.
build/toolchain/android/BUILD.gn
Outdated
| compiler_prefix = "$goma_dir/gomacc " | ||
| } else if (use_rbe) { | ||
| assert(!use_goma) | ||
| compiler_prefix = "$rbe_dir/rewrapper --server_address=unix:///tmp/reproxy.sock --labels=type=compile,compiler=clang,lang=cpp --exec_root=$exec_root --platform=container-image=docker://gcr.io/cloud-marketplace/google/debian11@sha256:69e2789c9f3d28c6a0f13b25062c240ee7772be1f5e6d41bb4680b63eae6b304 " |
There was a problem hiding this comment.
Could we inject these values via variables?
There was a problem hiding this comment.
These are now gn args declared in rbe.gni. I still need to update the linked flutter/engine PR to plumb them in the gn script.
zanderso
force-pushed
the
rbe
branch
2 times, most recently
from
4c42c3d to
824fa5f
Compare
| enable_deps_cache=true | ||
| xattr_digest=user.fuchsia.rbe.digest.sha256 | ||
| server_address=unix:///tmp/reproxy.sock | ||
| log_dir=/tmp |
There was a problem hiding this comment.
This file here is used for local build, and the dir should not be a problem.
I will make sure recipes to use a timestamp based dir when executed from CI/LED.
To pick up flutter/buildroot#758
To pick up flutter/buildroot#758
2 participants
See instructions on flutter/engine#45271