-
Notifications
You must be signed in to change notification settings - Fork 254
[Impeller] Add testonly STB config #754
Conversation
|
|
||
| source_root = "//third_party/stb" | ||
|
|
||
| source_set("stb_truetype") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could find a place for this to live in flutter/engine instead of in buildroot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put a tertiary build dir tree that in the engine itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be great. I added an issue about it here: flutter/flutter#132981.
If we move this build config into the engine tree, we should also move the other testonly deps I've added in the past like imgui and tinygltf, as they're in more or less the same situation.
|
|
||
| source_root = "//third_party/stb" | ||
|
|
||
| source_set("stb_truetype") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put a tertiary build dir tree that in the engine itself.
|
We discussed this in triage. But |
|
But that's what I was trying to address with the bug. Where should we start putting stuff like this in the engine repo? Maybe we could just throw it in as |
|
Yeah, this is sort of problematic with libraries that are header only but ask you to stamp out an implementation in exactly on TU by defining a |
For flutter/engine#44887.