Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 2, 2021

Instead of parsing the contents of Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs, parse xcodebuild -showsdks -json to query which SDKs are installed.

Fixes flutter/flutter#94513

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Dec 2, 2021
@jmagman jmagman requested review from cbracken and dnfield December 2, 2021 01:52
@jmagman jmagman merged commit 97e127a into flutter:master Dec 2, 2021
@jmagman jmagman deleted the find-xcode-sdk branch December 2, 2021 07:45
@jmagman jmagman changed the title Query Xcode for installed macOS SDKS instead of path parsing Query Xcode for installed macOS SDKs instead of path parsing Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildroot macOS SDK finder script fails on new Xcode cipd package: SDK "macosx10.15" cannot be located

3 participants