This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix toolchain for linux x86_64 #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2020 17:40
Change to match dart-sdk in x86/x64.
9 tasks
Member
Author
|
Thank you for your review. |
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
* Change readelf, nm, readelf, etc path in clang_x86/clang_x64. Change to match dart-sdk in x86/x64. * format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the
clang_x86andclang_x64building,buildroothas been using readelf/nm/ar/strip commands of a host that executes the build without using the toolchain's. However, it is odd to use gcc in the host environment even though it uses clang / llvm.#390 (review)
Changes
I investigated the past commit history of dart-sdk and flutter. I guess that the cause is that the changes of dart-sdk are not imported to flutter-engine.
dart-sdk was changed from gcc to clang/llvm by this PR on 21 May 2017. However, there isn't any changes in flutter. I don't think it's the critical problem, but I think it's better to modify the toolchain according to dart-sdk.
clang_x64 and clang_x86
Changed readelf, nm, ar, strip(llvm_objcopy) commands from gcc to clang/llvm. The source code is the same with dart-sdk's.
https://github.com/dart-lang/sdk/blob/master/build/toolchain/linux/BUILD.gn
x64 and x86
Formally, there isn't any changes without adding strip command. I just changed the code according to dart-sdk.
Test
The tests in the CI passed.
flutter/engine#22484