account for macos 11 too when looking for mac sdks #393
Conversation
| else: | ||
| sdk_dir = os.path.join(out.rstrip(), 'SDKs') | ||
| sdks = [re.findall('^MacOSX(10\.\d+)\.sdk$', s) for s in os.listdir(sdk_dir)] | ||
| sdks = [re.findall('^MacOSX(1[0|1]\.\d+)\.sdk$', s) for s in os.listdir(sdk_dir)] |
There was a problem hiding this comment.
no, we're going for 11 next https://en.wikipedia.org/wiki/MacOS_Big_Sur :D
There was a problem hiding this comment.
But the SDK is 10.16 https://appleinsider.com/inside/macos-10.16
drwxr-xr-x 5 magder primarygroup 160 Jun 29 16:01 DriverKit20.0.sdk
drwxr-xr-x 7 magder primarygroup 224 Jun 29 16:01 MacOSX.sdk
lrwxr-xr-x 1 magder primarygroup 10 Jul 8 13:45 MacOSX10.16.sdk -> MacOSX.sdk
There was a problem hiding this comment.
huh, interesting. There's some nuanced stuff going on... I'm getting
ll /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
total 0
drwxr-xr-x 5 xster staff 160B Jul 30 05:11 DriverKit20.0.sdk/
drwxr-xr-x 7 xster staff 224B Jul 30 05:11 MacOSX.sdk/
lrwxr-xr-x 1 xster staff 10B Aug 11 13:11 MacOSX11.0.sdk@ -> MacOSX.sdk
Which beta version you on? I'm on 4
There was a problem hiding this comment.
can't find any other discussions about this... https://developer.apple.com/documentation/xcode-release-notes/xcode-12-beta-release-notes says Xcode 12 beta 4 includes SDKs for iOS 14, iPadOS 14, tvOS 14, watchOS 7, and macOS 11 and nothing for beta 3. But macOS 11 here could also just be referencing the marketing term...
Would love to see what you get on Xcode 12 beta 4. I'm assuming you're not currently since Jul 8 is a bit older.
There was a problem hiding this comment.
I was on beta 2. You're right, it's MacOSX11.0.sdk on beta 4!
There was a problem hiding this comment.
ah cool, good to know. Either way, this should handle 10.16 or 11.0.
There was a problem hiding this comment.
Can we uses ^MacOSX\d+.*\.sdk$ so we don't need to do this again next year? It looks like it's trying to not match MacOSX.sdk
There was a problem hiding this comment.
Let's be conservative. I think it's not a bad thing for someone to come back and potentially touch this file again in case macos does decide to keep going up a major version every year.
2 participants
Fixes flutter/flutter#63613
Ran into it to debug flutter/flutter#60013