Conversation
|
LGTM. Did using chromium's repo not work? |
|
|
||
| assert(is_ios) | ||
|
|
||
| ocmock_path = "../../../../third_party/ocmock/Source" |
There was a problem hiding this comment.
// indicates starting from the buildroot. So just //third_party/ocmock/Source would suffice instead of counting up the number of directories to the root.
| ios_simulator_sdk_path = "" | ||
|
|
||
| # Version of iOS that we're targeting for tests. | ||
| ios_testing_deployment_target = "13.0" |
There was a problem hiding this comment.
The variables here apply to all targets (ldflags from the variables defined here are specified in build/toolchain/mac/BUILD.gn). Is there a reason tests can't be run on older simulators? In that case, you can just modify the toolchain definition.
There was a problem hiding this comment.
That would require us to edit OCMock's source code. The variable is meant to be a mirror to ios_deployment_target so it seems like it should be used the same way.
There was a problem hiding this comment.
I see, so its enforced by a dependency. ios_deployment_target is used in //build/toolchain/mac/BUILD.gn which applies that variable to all iOS targets. This is unlike ios_testing_deployment_target here which targets need to apply themselves (like in the case of ocmock).
Eh, this is only used in target. We can figure out how to make this consistent later.
Nope, I explained why in the issue: flutter/flutter#54503 |
| ios_simulator_sdk_path = "" | ||
|
|
||
| # Version of iOS that we're targeting for tests. | ||
| ios_testing_deployment_target = "13.0" |
There was a problem hiding this comment.
I see, so its enforced by a dependency. ios_deployment_target is used in //build/toolchain/mac/BUILD.gn which applies that variable to all iOS targets. This is unlike ios_testing_deployment_target here which targets need to apply themselves (like in the case of ocmock).
Eh, this is only used in target. We can figure out how to make this consistent later.
3 participants
relevant issues: