This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Switch Windows to VS 2019 toolchain #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 21, 2020
stuartmorgan-g
pushed a commit
that referenced
this pull request
Jan 22, 2020
This reverts commit 3c32883.
stuartmorgan-g
added a commit
that referenced
this pull request
Jan 22, 2020
gw280
pushed a commit
to gw280/buildroot
that referenced
this pull request
Feb 4, 2020
Mirrors the change from https://chromium.googlesource.com/chromium/src/+/8e82c6ab1bc2223fa25f1a127b65071d2d58ae36%5E%21/ Also adds a new variable needed to build ToT ANGLE. This is because the toolchain change is unfortunately linked to rolling ANGLE at the same time, since the current ANGLE pull has build errors under VS 2017, but ToT hits internal compiler errors with the old toolchain, so they need to be updated in lockstep. Part of fix for flutter/flutter#48831
gw280
pushed a commit
to gw280/buildroot
that referenced
this pull request
Feb 4, 2020
This reverts commit 3c32883.
stuartmorgan-g
added a commit
that referenced
this pull request
Apr 30, 2020
Mirrors the change from https://chromium.googlesource.com/chromium/src/+/8e82c6ab1bc2223fa25f1a127b65071d2d58ae36%5E%21/ Also adds a new variable needed to build ToT ANGLE. This is because the toolchain change is unfortunately linked to rolling ANGLE at the same time, since the current ANGLE pull has build errors under VS 2017, but ToT hits internal compiler errors with the old toolchain, so they need to be updated in lockstep. Part of fix for flutter/flutter#48831
stuartmorgan-g
added a commit
to stuartmorgan-g/buildroot
that referenced
this pull request
Jun 10, 2020
Merged
stuartmorgan-g
added a commit
that referenced
this pull request
Aug 11, 2020
GaryQian
added a commit
that referenced
this pull request
Aug 15, 2020
stuartmorgan-g
added a commit
to stuartmorgan-g/buildroot
that referenced
this pull request
Sep 22, 2020
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Mirrors the change from https://chromium.googlesource.com/chromium/src/+/8e82c6ab1bc2223fa25f1a127b65071d2d58ae36%5E%21/ Also adds a new variable needed to build ToT ANGLE. This is because the toolchain change is unfortunately linked to rolling ANGLE at the same time, since the current ANGLE pull has build errors under VS 2017, but ToT hits internal compiler errors with the old toolchain, so they need to be updated in lockstep. Part of fix for flutter/flutter#48831
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This reverts commit 3c32883.
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
…" (flutter#396) This reverts commit 97f6f00.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors the change from https://chromium.googlesource.com/chromium/src/+/8e82c6ab1bc2223fa25f1a127b65071d2d58ae36%5E%21/
Also adds a new variable needed to build ToT ANGLE and rolls ANGLE. The toolchain change is unfortunately linked to rolling ANGLE at the same time, since the current ANGLE pull has build errors under VS 2017, but ToT hits internal compiler errors with the old toolchain, so they need to be updated in lockstep.
Part of fix for flutter/flutter#48831