This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Disable global static thread safety analysis and enable RTTI in libcxx. #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks flutter/engine#13123 * We should only enable static thread safety checks for Flutter translation units. Not all third party code is correctly annotated for static checks. This will be enabled seprately in //flutter. * Allow third party users of libcxx to use RTTI (used by ICU).
Member
Author
|
cc @filmil |
jason-simmons
approved these changes
Oct 14, 2019
chinmaygarde
added a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
…x. (flutter#326) Unblocks flutter/engine#13123 * We should only enable static thread safety checks for Flutter translation units. Not all third party code is correctly annotated for static checks. This will be enabled seprately in //flutter. * Allow third party users of libcxx to use RTTI (used by ICU).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks flutter/engine#13123