[video_player] Migrate to pigeon-generated code #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #348.
The platform interface package's default implementation has recently been removed (flutter/plugins#6341) and the platform interface must be explicitly implemented by each platform package.
Pigeon (4.2.9) was used to auto-generate the binding code (Dart and C++) in this PR. Currently pigeon's C++ generator has this bug and the Tizen SDK (which uses Clang as a compiler) emits an error when compiling the generated code. I applied the following patch before running
flutter pub run pigeonto mitigate the issue.Notes:
pigeons/messages.dart) is a copy of video_player_android'smessages.dartwith a few minor changes (seekTois marked@async).video_player_tizen.dartis a copy of video_player_android'sandroid_video_player.dartwith a few minor changes.