Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
- packages/wakelock/**/*
"p: wearable_rotary":
- packages/wearable_rotary/**/*
"p: webview_flutter":
- packages/webview_flutter/**/*
"p: webview_flutter_lwe":
- packages/webview_flutter_lwe/**/*

# Tools
"tools":
Expand Down
2 changes: 1 addition & 1 deletion .github/recipe.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ plugins:
camera: []
google_maps_flutter: []
network_info_plus: []
webview_flutter: []
webview_flutter_lwe: []

# No tests.
google_sign_in: []
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The _"non-endorsed"_ status means that the plugin is not endorsed by the origina
| [**video_player_tizen**](packages/video_player) | [video_player](https://github.com/flutter/plugins/tree/main/packages/video_player) (1st-party) | [![pub package](https://img.shields.io/pub/v/video_player_tizen.svg)](https://pub.dev/packages/video_player_tizen) | No |
| [**wakelock_tizen**](packages/wakelock) | [wakelock](https://github.com/creativecreatorormaybenot/wakelock) (3rd-party) | [![pub package](https://img.shields.io/pub/v/wakelock_tizen.svg)](https://pub.dev/packages/wakelock_tizen) | No |
| [**wearable_rotary**](packages/wearable_rotary) | (Tizen-only) | [![pub package](https://img.shields.io/pub/v/wearable_rotary.svg)](https://pub.dev/packages/wearable_rotary) | N/A |
| [**webview_flutter_tizen**](packages/webview_flutter) | [webview_flutter](https://github.com/flutter/plugins/tree/main/packages/webview_flutter) (1st-party) | [![pub package](https://img.shields.io/pub/v/webview_flutter_tizen.svg)](https://pub.dev/packages/webview_flutter_tizen) | No |
| [**webview_flutter_lwe**](packages/webview_flutter) | [webview_flutter](https://github.com/flutter/plugins/tree/main/packages/webview_flutter) (1st-party) | [![pub package](https://img.shields.io/pub/v/webview_flutter_tizen.svg)](https://pub.dev/packages/webview_flutter_lwe) | No |
Comment thread
swift-kim marked this conversation as resolved.
Outdated

## Device limitations

Expand Down Expand Up @@ -84,4 +84,5 @@ The _"non-endorsed"_ status means that the plugin is not endorsed by the origina
| [**video_player_tizen**](packages/video_player) | 4.0 | ✔️ | ✔️ | ⚠️ | ❌ | Functional limitations,<br>TV emulator issue |
| [**wakelock_tizen**](packages/wakelock) | 4.0 | ✔️ | ✔️ | ❌ | ❌ | Cannot override system settings |
| [**wearable_rotary**](packages/wearable_rotary) | 4.0 | ✔️ | ✔️ | ❌ | ❌ | Not applicable for TV |
| [**webview_flutter_tizen**](packages/webview_flutter) | 5.5 | ✔️ | ✔️ | ✔️ | ✔️ | Not for production use |
| [**webview_flutter_lwe**](packages/webview_flutter_lwe) | 5.5 | ✔️ | ✔️ | ✔️ | ✔️ | Not for production use |

13 changes: 0 additions & 13 deletions packages/webview_flutter/example/tizen/tizen-manifest.xml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.7

* The plugin is renamed to webview_flutter_lwe.

## 0.5.6

* Update LWE binary (9af6ea4101d173935fe6e6cd3f2c91ca17ed451e).
Expand Down Expand Up @@ -121,7 +125,7 @@

* Update Dart and Flutter SDK constraints.
* Update Flutter and Samsung copyright information.
* Update webview_flutter_tizen to use platform view interface.
* Update webview_flutter_lwe to use platform view interface.
Comment thread
swift-kim marked this conversation as resolved.
Outdated
* Update example and integration_test.
* Update webivew_flutter to 2.0.4.

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# webview_flutter_tizen
# webview_flutter_lwe

[![pub package](https://img.shields.io/pub/v/webview_flutter_tizen.svg)](https://pub.dev/packages/webview_flutter_tizen)
[![pub package](https://img.shields.io/pub/v/webview_flutter_lwe.svg)](https://pub.dev/packages/webview_flutter_lwe)

The Tizen implementation of [`webview_flutter`](https://github.com/flutter/plugins/tree/main/packages/webview_flutter).
The Tizen implementation of [`webview_flutter`](https://github.com/flutter/plugins/tree/master/packages/webview_flutter).
Comment thread
swift-kim marked this conversation as resolved.
Outdated

## Required privileges

Expand All @@ -16,12 +16,12 @@ To use this plugin, add below lines under the `<manifest>` section in your `tize

## Usage

This package is not an _endorsed_ implementation of `webview_flutter`. Therefore, you have to include `webview_flutter_tizen` alongside `webview_flutter` as dependencies in your `pubspec.yaml` file.
This package is not an _endorsed_ implementation of `webview_flutter`. Therefore, you have to include `webview_flutter_lwe` alongside `webview_flutter` as dependencies in your `pubspec.yaml` file.

```yaml
dependencies:
webview_flutter: ^3.0.4
webview_flutter_tizen: ^0.5.6
webview_flutter_lwe: ^0.5.7
```

## Example
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# webview_flutter_tizen_example
# webview_flutter_lwe_example

Demonstrates how to use the webview_flutter_tizen plugin.
Demonstrates how to use the webview_flutter_lwe plugin.

## Getting Started

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: webview_flutter_tizen_example
description: Demonstrates how to use the webview_flutter_tizen plugin.
name: webview_flutter_lwe_example
description: Demonstrates how to use the webview_flutter_lwe plugin.
publish_to: none

environment:
Expand All @@ -13,7 +13,7 @@ dependencies:
path_provider_tizen:
path: ../../path_provider/
webview_flutter: ^3.0.4
webview_flutter_tizen:
webview_flutter_lwe:
path: ../

dev_dependencies:
Expand Down
13 changes: 13 additions & 0 deletions packages/webview_flutter_lwe/example/tizen/tizen-manifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="org.tizen.webview_flutter_lwe_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
<profile name="common"/>
<ui-application appid="org.tizen.webview_flutter_lwe_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" launch_mode="single">
<label>webview_flutter_lwe_example</label>
<icon>ic_launcher.png</icon>
<metadata key="http://tizen.org/metadata/prefer_dotnet_aot" value="true" />
</ui-application>
<privileges>
<privilege>http://tizen.org/privilege/internet</privilege>
</privileges>
<feature name="http://tizen.org/feature/screen.size.all"/>
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// ignore_for_file: public_member_api_docs

part of '../webview_flutter_tizen.dart';
part of '../webview_flutter_lwe.dart';

enum _PlatformViewState {
uninitialized,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ part 'src/platform_view_tizen.dart';
///
/// This is used as the default implementation for [WebView.platform] on Tizen. It uses a method channel to
/// communicate with the platform code.
class TizenWebView implements WebViewPlatform {
class LweWebView implements WebViewPlatform {
/// Sets a tizen [WebViewPlatform].
static void register() {
WebView.platform = TizenWebView();
WebView.platform = LweWebView();
WebViewCookieManagerPlatform.instance = WebViewTizenCookieManager();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: webview_flutter_tizen
description: Tizen implementation of the webview plugin
name: webview_flutter_lwe
description: Tizen implementation of the webview plugin using lwe
Comment thread
swift-kim marked this conversation as resolved.
Outdated
homepage: https://github.com/flutter-tizen/plugins
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter
version: 0.5.6
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter_lwe
version: 0.5.7

environment:
sdk: ">=2.17.0 <3.0.0"
Expand All @@ -12,9 +12,9 @@ flutter:
plugin:
platforms:
tizen:
pluginClass: WebviewFlutterTizenPlugin
fileName: webview_flutter_tizen_plugin.h
dartPluginClass: TizenWebView
pluginClass: WebviewFlutterLwePlugin
fileName: webview_flutter_lwe_plugin.h
dartPluginClass: LweWebView

dependencies:
flutter:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef FLUTTER_PLUGIN_WEBVIEW_FLUTTER_TIZEN_PLUGIN_H_
#define FLUTTER_PLUGIN_WEBVIEW_FLUTTER_TIZEN_PLUGIN_H_
#ifndef FLUTTER_PLUGIN_WEBVIEW_FLUTTER_LWE_PLUGIN_H_
#define FLUTTER_PLUGIN_WEBVIEW_FLUTTER_LWE_PLUGIN_H_

#include <flutter_plugin_registrar.h>

Expand All @@ -13,11 +13,11 @@
extern "C" {
#endif

FLUTTER_PLUGIN_EXPORT void WebviewFlutterTizenPluginRegisterWithRegistrar(
FLUTTER_PLUGIN_EXPORT void WebviewFlutterLwePluginRegisterWithRegistrar(
FlutterDesktopPluginRegistrarRef registrar);

#if defined(__cplusplus)
} // extern "C"
#endif

#endif // FLUTTER_PLUGIN_WEBVIEW_FLUTTER_TIZEN_PLUGIN_H_
#endif // FLUTTER_PLUGIN_WEBVIEW_FLUTTER_LWE_PLUGIN_H_
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See https://docs.tizen.org/application/tizen-studio/native-tools/project-conversion
# for details.

APPNAME = webview_flutter_tizen_plugin
APPNAME = webview_flutter_lwe_plugin
type = sharedLib
profile = common-5.5

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#ifdef LOG_TAG
#undef LOG_TAG
#endif
#define LOG_TAG "WebviewFlutterTizenPlugin"
#define LOG_TAG "WebviewFlutterLwePlugin"

#ifndef __MODULE__
#define __MODULE__ strrchr("/" __FILE__, '/') + 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "webview_flutter_tizen_plugin.h"
#include "webview_flutter_lwe_plugin.h"

#include <flutter/plugin_registrar.h>
#include <flutter_tizen.h>
Expand All @@ -15,26 +15,26 @@ namespace {

constexpr char kViewType[] = "plugins.flutter.io/webview";

class WebviewFlutterTizenPlugin : public flutter::Plugin {
class WebviewFlutterLwePlugin : public flutter::Plugin {
public:
static void RegisterWithRegistrar(flutter::PluginRegistrar* registrar) {
auto plugin = std::make_unique<WebviewFlutterTizenPlugin>();
auto plugin = std::make_unique<WebviewFlutterLwePlugin>();
registrar->AddPlugin(std::move(plugin));
}

WebviewFlutterTizenPlugin() {}
WebviewFlutterLwePlugin() {}

virtual ~WebviewFlutterTizenPlugin() {}
virtual ~WebviewFlutterLwePlugin() {}
};

} // namespace

void WebviewFlutterTizenPluginRegisterWithRegistrar(
void WebviewFlutterLwePluginRegisterWithRegistrar(
FlutterDesktopPluginRegistrarRef core_registrar) {
flutter::PluginRegistrar* registrar =
flutter::PluginRegistrarManager::GetInstance()
->GetRegistrar<flutter::PluginRegistrar>(core_registrar);
FlutterDesktopRegisterViewFactory(
core_registrar, kViewType, std::make_unique<WebViewFactory>(registrar));
WebviewFlutterTizenPlugin::RegisterWithRegistrar(registrar);
WebviewFlutterLwePlugin::RegisterWithRegistrar(registrar);
}