Skip to content

Conversation

@bwikbs
Copy link
Member

@bwikbs bwikbs commented Jun 9, 2022

  • This is almost same as the webview_flutter_tizen except for backend web engine.

Signed-off-by: MuHong Byun [email protected]

@bwikbs bwikbs force-pushed the ewk_webview_flutter branch 3 times, most recently from 3202683 to 6daa055 Compare June 9, 2022 06:31
@bwikbs bwikbs force-pushed the ewk_webview_flutter branch from 6daa055 to 7836fb4 Compare June 23, 2022 23:07
@haesik
Copy link
Member

haesik commented Jun 24, 2022

Can you tell me which source code is based on?
I mean, Where did the ewk header files come from?

@bwikbs
Copy link
Member Author

bwikbs commented Jun 27, 2022

@haesik
These headers are the most up-to-date code at the moment of work.
Currently, this PR is only for checking if ewk is available.
We need a more discussion regarding ewk version. Because there is a problem like key event handling still remaining.

@bwikbs bwikbs force-pushed the ewk_webview_flutter branch 2 times, most recently from b43b8fb to 6824991 Compare June 28, 2022 04:29
* This is almost same as the webview_flutter_tizen except for backend web engine.

Signed-off-by: MuHong Byun <[email protected]>
@bwikbs bwikbs force-pushed the ewk_webview_flutter branch from 6824991 to 50ac06e Compare July 21, 2022 06:52
eina_list_free(pointList);
}

bool WebView::SendKey(const char* key, const char* string, const char* compose,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a report about crash with key input. so I tried to fix it. @bwikbs could you review my fix?

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 11, 2022

I got a requirement to show software keyboard on ewk webview.

This patch to allow showing software keyboard on ewk webview.

Note: FlutterDesktopPluginRegistrarGetNativeWindow is under refactoring at here
cc. @haesik, @Swanseo0

@haesik
Copy link
Member

haesik commented Aug 11, 2022

@bwikbs Can you please update the ewk webview using the [patch] (bbrto21@2fa5705) immediately.

@bwikbs
Copy link
Member Author

bwikbs commented Aug 11, 2022

I got a requirement to show software keyboard on ewk webview.

This patch to allow showing software keyboard on ewk webview.

Note: FlutterDesktopPluginRegistrarGetNativeWindow is under refactoring at here cc. @haesik, @Swanseo0

Thank you!
BTW Can you give me a PR? Then I think it would be better to apply!

@bwikbs
Copy link
Member Author

bwikbs commented Aug 11, 2022

@bwikbs Can you please update the ewk webview using the [patch] (bbrto21@2fa5705) immediately.

Got it!

@bbrto21
Copy link
Contributor

bbrto21 commented Aug 11, 2022

I just opened 2 PR on @bwikbs repo.

@Swanseo0
Copy link
Contributor

I opened PR on @bwikbs repo for the change of FlutterDesktopPluginRegistrarGetNativeWindow.

@bwikbs
Copy link
Member Author

bwikbs commented Nov 16, 2022

Continued in #479

@bwikbs bwikbs closed this Nov 16, 2022
bbrto21 added a commit that referenced this pull request Nov 17, 2022
* This PR based on #400.
* It provides a much more reliable user experience about web browsing than using LWE.
* But EWK's offscreen rendering only works well on TV devices, so other devices and emulators are not supported.

Signed-off-by: Boram Bae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants