[webview_flutter] Migrate to new analysis options

packages/webview_flutter/CHANGELOG.md

@@ -1,7 +1,8 @@
-## NEXT
+## 0.5.0
 
 * Code refactoring.
-* Update the example app.
+* Update the example app and integration_test.
+* Sync with the latest framework code.
 * Migrate to new analysis options.
 
 ## 0.4.4

packages/webview_flutter/README.md

@@ -24,8 +24,8 @@ This package is not an _endorsed_ implementation of `webview_flutter`. Therefore
 
 ```yaml
 dependencies:
-  webview_flutter: ^3.0.2
-  webview_flutter_tizen: ^0.4.4
+  webview_flutter: ^3.0.4
+  webview_flutter_tizen: ^0.5.0
 ```
 
 ## Example

packages/webview_flutter/example/tizen/tizen-manifest.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest package="org.tizen.webview_flutter_tizen_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
-    <profile name="mobile"/>
+    <profile name="common"/>
     <ui-application appid="org.tizen.webview_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" api-version="4" launch_mode="single">
         <label>webview_flutter_tizen_example</label>
         <icon>ic_launcher.png</icon>

packages/webview_flutter/lib/src/platform_view_tizen.dart

@@ -14,9 +14,15 @@
 
 part of '../webview_flutter_tizen.dart';
 
+enum _PlatformViewState {
+  uninitialized,
+  resizing,
+  ready,
+}
+
 class TizenView extends StatefulWidget {
   const TizenView({
-    Key? key,
+    super.key,
     required this.viewType,
     this.onPlatformViewCreated,
     this.hitTestBehavior = PlatformViewHitTestBehavior.opaque,
@@ -27,8 +33,7 @@ class TizenView extends StatefulWidget {
     this.clipBehavior = Clip.hardEdge,
   })  : assert(viewType != null),
         assert(hitTestBehavior != null),
-        assert(creationParams == null || creationParamsCodec != null),
-        super(key: key);
+        assert(creationParams == null || creationParamsCodec != null);
 
   final String viewType;
   final PlatformViewCreatedCallback? onPlatformViewCreated;
@@ -144,7 +149,6 @@ class _TizenWebViewState extends State<TizenView> {
     if (!_controller.isCreated) {
       return;
     }
-
     if (!isFocused) {
       _controller.clearFocus().catchError((dynamic e) {
         if (e is MissingPluginException) {
@@ -153,12 +157,10 @@ class _TizenWebViewState extends State<TizenView> {
       });
       return;
     }
-    SystemChannels.textInput
-        .invokeMethod<void>(
+    SystemChannels.textInput.invokeMethod<void>(
       'TextInput.setPlatformViewClient',
-      _id,
-    )
-        .catchError((dynamic e) {
+      <String, dynamic>{'platformViewId': _id},
+    ).catchError((dynamic e) {
       if (e is MissingPluginException) {
         return;
       }
@@ -457,7 +459,7 @@ class PlatformViewsServiceTizen {
 /// See also:
 ///
 ///  * [PlatformViewsService] which is a service for controlling platform views.
-class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
+class RenderTizenView extends PlatformViewRenderBox {
   /// Creates a render object for an Tizen view.
   RenderTizenView({
     required TizenViewController viewController,
@@ -467,8 +469,13 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
   })  : assert(viewController != null),
         assert(hitTestBehavior != null),
         assert(gestureRecognizers != null),
+        assert(clipBehavior != null),
         _viewController = viewController,
-        _clipBehavior = clipBehavior {
+        _clipBehavior = clipBehavior,
+        super(
+            controller: viewController,
+            hitTestBehavior: hitTestBehavior,
+            gestureRecognizers: gestureRecognizers) {
     updateGestureRecognizers(gestureRecognizers);
     _viewController.addOnPlatformViewCreatedListener(_onPlatformViewCreated);
     this.hitTestBehavior = hitTestBehavior;
@@ -478,12 +485,15 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
 
   Size? _currentTextureSize;
 
+  @override
   TizenViewController get controller => _viewController;
+
   TizenViewController _viewController;
 
   /// Sets a new Tizen view controller.
   ///
   /// `viewController` must not be null.
+  @override
   set controller(TizenViewController viewController) {
     assert(_viewController != null);
     assert(viewController != null);
@@ -517,12 +527,6 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
     markNeedsSemanticsUpdate();
   }
 
-  void updateGestureRecognizers(
-      Set<Factory<OneSequenceGestureRecognizer>> gestureRecognizers) {
-    _updateGestureRecognizersWithCallBack(
-        gestureRecognizers, _viewController.dispatchPointerEvent);
-  }
-
   @override
   bool get sizedByParent => true;
 
@@ -623,15 +627,13 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
 
 class _TizenPlatformTextureView extends LeafRenderObjectWidget {
   const _TizenPlatformTextureView({
-    Key? key,
     required this.controller,
     required this.hitTestBehavior,
     required this.gestureRecognizers,
     this.clipBehavior = Clip.hardEdge,
   })  : assert(controller != null),
         assert(hitTestBehavior != null),
-        assert(gestureRecognizers != null),
-        super(key: key);
+        assert(gestureRecognizers != null);
 
   final TizenViewController controller;
   final PlatformViewHitTestBehavior hitTestBehavior;

packages/webview_flutter/lib/webview_flutter_tizen.dart

@@ -15,7 +15,6 @@ import 'package:flutter/widgets.dart';
 import 'package:webview_flutter/webview_flutter.dart';
 import 'package:webview_flutter_platform_interface/webview_flutter_platform_interface.dart';
 
-part 'src/platform_view.dart';
 part 'src/platform_view_tizen.dart';
 
 /// Builds an Tizen webview.