Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@
- packages/path_provider/**/*
'p: permission_handler':
- packages/permission_handler/**/*
'p: sensors_plus':
- packages/sensors_plus/**/*
'p: shared_preferences':
- packages/shared_preferences/**/*
'p: sensors_plus':
- packages/sensors_plus/**/*
Comment thread
swift-kim marked this conversation as resolved.
'p: sqflite':
- packages/sqflite/**/*
'p: share_plus':
- packages/share_plus/**/*
'p: tizen_app_control':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import 'package:integration_test_example/main.dart' as app;

void main() {
final IntegrationTestWidgetsFlutterBinding binding =
// ignore: unnecessary_cast
IntegrationTestWidgetsFlutterBinding.ensureInitialized()
as IntegrationTestWidgetsFlutterBinding;
Comment thread
swift-kim marked this conversation as resolved.
Outdated
testWidgets('verify text', (WidgetTester tester) async {
Expand Down
2 changes: 2 additions & 0 deletions packages/sqflite/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class MyApp extends StatefulWidget {
// This widget is the root of your application.

@override
// ignore: library_private_types_in_public_api
_MyAppState createState() => _MyAppState();
}

Expand Down Expand Up @@ -133,6 +134,7 @@ class MyHomePage extends StatefulWidget {
final String? title;

@override
// ignore: library_private_types_in_public_api
_MyHomePageState createState() => _MyHomePageState();
}

Expand Down
15 changes: 9 additions & 6 deletions packages/sqflite/example/lib/manual_test_page.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:flutter/material.dart' hide MenuItem;
Comment thread
swift-kim marked this conversation as resolved.
Outdated
import 'package:sqflite/sqflite.dart';
// ignore: implementation_imports
import 'package:sqflite/src/factory_mixin.dart' as impl;
Expand All @@ -17,6 +17,7 @@ class ManualTestPage extends StatefulWidget {
const ManualTestPage({Key? key}) : super(key: key);

@override
// ignore: library_private_types_in_public_api
_ManualTestPageState createState() => _ManualTestPageState();
}

Expand Down Expand Up @@ -185,6 +186,7 @@ class SimpleDbTestPage extends StatefulWidget {
final String dbName;

@override
// ignore: library_private_types_in_public_api
_SimpleDbTestPageState createState() => _SimpleDbTestPageState();
}

Expand Down Expand Up @@ -233,11 +235,12 @@ class _SimpleDbTestPageState extends State<SimpleDbTestPage> {
final result =
firstIntValue(await db.query('test', columns: ['COUNT(*)']));
// Temp for nnbd successfull lint
// ignore: deprecated_member_use
Scaffold.of(context).showSnackBar(SnackBar(
content: Text('$result records'),
duration: const Duration(milliseconds: 700),
));
if (mounted) {
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
content: Text('$result records'),
duration: const Duration(milliseconds: 700),
));
}
}

final items = <Widget>[
Expand Down
3 changes: 1 addition & 2 deletions packages/sqflite/example/lib/open_test_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart' show rootBundle;
import 'package:flutter/services.dart';
import 'package:path/path.dart';
import 'package:pedantic/pedantic.dart';
import 'package:sqflite/sqflite.dart';
import 'package:sqflite/src/database_mixin.dart' // ignore: implementation_imports
show
Expand Down Expand Up @@ -142,7 +141,7 @@ class OpenTestPage extends TestPage {
test('Databases path', () async {
final databasesPath = await factory.getDatabasesPath();
// On Android we know it is current a 'databases' folder in the package folder
print('databasesPath: ' + databasesPath);
print('databasesPath: $databasesPath');
if (Platform.isAndroid) {
expect(basename(databasesPath), 'databases');
} else if (Platform.isIOS) {
Expand Down
1 change: 1 addition & 0 deletions packages/sqflite/example/lib/src/item_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class ItemWidget extends StatefulWidget {
final Function(Item item) onTap; // = Function(MainItem item);

@override
// ignore: library_private_types_in_public_api
_ItemWidgetState createState() => _ItemWidgetState();
}

Expand Down
1 change: 1 addition & 0 deletions packages/sqflite/example/lib/src/main_item_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class MainItemWidget extends StatefulWidget {
final Function(MainItem item) onTap; // = Function(MainItem item);

@override
// ignore: library_private_types_in_public_api
_MainItemWidgetState createState() => _MainItemWidgetState();
}

Expand Down
1 change: 1 addition & 0 deletions packages/sqflite/example/lib/test_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class TestPage extends StatefulWidget {
}

@override
// ignore: library_private_types_in_public_api
_TestPageState createState() => _TestPageState();
}

Expand Down
1 change: 1 addition & 0 deletions packages/sqflite/example/lib/type_test_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ class TypeTestPage extends TestPage {
}

/// Out internal data.
// ignore: library_private_types_in_public_api
final _Data data = _Data();

/// Get the value field from a given id
Expand Down
7 changes: 6 additions & 1 deletion packages/sqflite/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,17 @@ environment:
sdk: ">=2.12.0 <3.0.0"

dependencies:
path: any
collection: any
flutter:
sdk: flutter
sqflite: ^2.0.0
sqflite_common:
sqflite_tizen:
path: ../
synchronized:
matcher:
meta:

dev_dependencies:
pedantic: ^1.11.0
Expand All @@ -24,7 +30,6 @@ dev_dependencies:
integration_test_tizen:
path: ../../integration_test/
test:
matcher: '>=0.12.10-nullsafety.3 <2.0.0'
process_run: '>=0.11.0+2'

flutter:
Expand Down
1 change: 1 addition & 0 deletions packages/webview_flutter/lib/src/platform_view_tizen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ class _TizenPlatformTextureView extends LeafRenderObjectWidget {
required this.controller,
required this.hitTestBehavior,
required this.gestureRecognizers,
// ignore: unused_element
this.clipBehavior = Clip.hardEdge,
Comment thread
swift-kim marked this conversation as resolved.
Outdated
}) : assert(controller != null),
assert(hitTestBehavior != null),
Expand Down