Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url_launcher] Reimplement based on tizen_app_control #288

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

swift-kim
Copy link
Member

Known issue (not caused by this PR): When a launch request is made with no browser app installed on the device, a PlatformException is thrown. In the example app of this plugin, the exception should be handled by a Future error callback inside FutureBuilder, but sometimes "Unhandled Exception" error message is printed out to the console unexpectedly. The symptom is very random and isn't even consistent across devices (tested on mobile emulator, TM1, and watch). It could be a bug in the Dart runtime or the Flutter engine.

[I] flutter: ConnectionState.waiting, hasError: true
[I] flutter: ConnectionState.done, hasError: true
[I] flutter: ConnectionState.waiting, hasError: true
[I] flutter: ConnectionState.done, hasError: true
[I] flutter: ConnectionState.waiting, hasError: true
[I] flutter: ConnectionState.done, hasError: true
[E] [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: PlatformException(-17825759, The application is not found, null, null)
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:607)
#1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156)
<asynchronous suspension>
#2      AppControl.sendLaunchRequest (package:tizen_app_control/app_control.dart:180)
<asynchronous suspension>
#3      UrlLauncherPlugin.launch (package:url_launcher_tizen/url_launcher_tizen.dart:43)
<asynchronous suspension>
#4      launch (package:url_launcher/url_launcher.dart:101)
<asynchronous suspension>
#5      _MyHomePageState._launchInBrowser (package:url_launcher_example/main.dart:55)
<asynchronous suspension>
[I] flutter: ConnectionState.waiting, hasError: true
[I] flutter: ConnectionState.done, hasError: true

@github-actions github-actions bot added needs-publishing The package should be published after merge p: url_launcher labels Dec 3, 2021
..setUri(url)
..sendLaunchRequest()
..destroy();
await AppControl(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@swift-kim swift-kim changed the title [url_launcher] Reimplement by adding tizen_app_control dependency [url_launcher] Reimplement based on tizen_app_control Dec 7, 2021
@swift-kim swift-kim merged commit 365d9fa into flutter-tizen:master Dec 8, 2021
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-publishing The package should be published after merge p: url_launcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants