Skip to content

Fix statics analysis issues #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift-kim merged 1 commit into from
Nov 9, 2021
Merged

Fix statics analysis issues #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/tizen/channels/text_input_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ void TextInputChannel::HandleMethodCall(
if (composing_base_value == -1 && composing_extent_value == -1) {
active_model_->EndComposing();
} else {
size_t composing_start =
std::min(composing_base_value, composing_extent_value);
size_t composing_start = static_cast<size_t>(
std::min(composing_base_value, composing_extent_value));
size_t cursor_offset = selection_base_value - composing_start;

active_model_->SetComposingRange(
Expand Down
4 changes: 2 additions & 2 deletions shell/platform/tizen/flutter_tizen_engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,8 @@ void FlutterTizenEngine::SendWindowMetrics(int32_t width,
double pixel_ratio) {
FlutterWindowMetricsEvent event = {};
event.struct_size = sizeof(FlutterWindowMetricsEvent);
event.width = width;
event.height = height;
event.width = static_cast<size_t>(width);
event.height = static_cast<size_t>(height);
if (pixel_ratio == 0.0) {
// The scale factor is computed based on the display DPI and the current
// profile. A fixed DPI value (72) is used on TVs. See:
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/tizen/public/flutter_platform_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ class PlatformView {
class PlatformViewFactory {
public:
PlatformViewFactory(flutter::PluginRegistrar* registrar)
: registrar_(registrar),
: platform_window_(nullptr),
registrar_(registrar),
codec_(flutter::StandardMessageCodec::GetInstance(nullptr)) {}
virtual ~PlatformViewFactory() {}
flutter::PluginRegistrar* GetPluginRegistrar() { return registrar_; }
Expand Down
1 change: 0 additions & 1 deletion shell/platform/tizen/tizen_input_method_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const char* GetEcoreImfContextAvailableId() {

Ecore_IMF_Input_Panel_Layout TextInputTypeToEcoreIMFInputPanelLayout(
const std::string& text_input_type) {
FT_ASSERT(panel_layout);
if (text_input_type == "TextInputType.text" ||
text_input_type == "TextInputType.multiline") {
return ECORE_IMF_INPUT_PANEL_LAYOUT_NORMAL;
Expand Down