Introduce spawn API at embedder #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]>
bwikbs
force-pushed
the
experimental_FlutterEngineGroup
branch
from
63c7aa7 to
f18858b
Compare
bbrto21
reviewed
Jun 22, 2021
Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bbrto21
reviewed
Jun 22, 2021
Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bbrto21
approved these changes
Jun 22, 2021
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Jun 22, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Jul 21, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
that referenced
this pull request
Jul 22, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Jul 23, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Aug 2, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Aug 6, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Aug 10, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Aug 30, 2021
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Apr 10, 2022
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]> Add test shell(multiple-flutters_shell) * This shell was created to run the following samples on x64. (https://github.com/flutter/samples/tree/master/add_to_app/multiple_flutters) * Apply upstream version Signed-off-by: MuHong Byun <[email protected]> Support external display output * using eom module (https://docs.tizen.org/application/native/guides/device/ext-output/) Signed-off-by: MuHong Byun <[email protected]>
bwikbs
added a commit
to bwikbs/engine
that referenced
this pull request
Apr 12, 2022
* Introduce spawn API at embedder * This uses Shell's Spawn. Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply Extract Method pattern at FlutterTizenEngine Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]> Add test shell(multiple-flutters_shell) * This shell was created to run the following samples on x64. (https://github.com/flutter/samples/tree/master/add_to_app/multiple_flutters) * Apply upstream version Signed-off-by: MuHong Byun <[email protected]> Support external display output * using eom module (https://docs.tizen.org/application/native/guides/device/ext-output/) Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC implementation to test the spawn API.