This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Enable Mac ios_platform_tests tests #6682
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,99 @@ targets: | |
| target_file: mac_build_all_plugins.yaml | ||
| channel: stable | ||
|
|
||
| ### iOS tasks ### | ||
| # TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator | ||
| # tests are reliable on the ARM infrastructure. See discussion at | ||
| # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089 | ||
| - name: Max_x64 ios_platform_tests_0_4 master | ||
|
Contributor
There was a problem hiding this comment. Is there any plan to building matricies into Cocoon? Having to specify each of these explicitly is much more verbose and error prone than the Cirrus matrix spec. It would also be a huge pain to change the sharding (which we do occasionally) since instead of being able to do a single PR—including the ability to iterate in presubmit to see what the best number of shards is, which is usually what we have done in the past—we'll need to add a whole duplicate set in bringup, land them, see how they go, iterate in post-submit with new PRs if necessary, and then finally do a last PR to switch over.
Contributor
Author
There was a problem hiding this comment. A generic builder will do the trick. It has been planned for release branches (flutter/flutter#97265), and we can do the same for main/master. |
||
| recipe: plugins/plugins | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 0 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_1_4 master | ||
| recipe: plugins/plugins | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 1 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_2_4 master | ||
| recipe: plugins/plugins | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 2 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_3_4 master | ||
| recipe: plugins/plugins | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 3 --shardCount 4" | ||
|
|
||
| # Don't run full platform tests on both channels in pre-submit. | ||
| - name: Max_x64 ios_platform_tests_0_4 stable | ||
| recipe: plugins/plugins | ||
| presubmit: false | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| channel: stable | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_stable.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 0 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_1_4 stable | ||
| recipe: plugins/plugins | ||
| presubmit: false | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| channel: stable | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_stable.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 1 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_2_4 stable | ||
| recipe: plugins/plugins | ||
| presubmit: false | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| channel: stable | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_stable.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 2 --shardCount 4" | ||
|
|
||
| - name: Max_x64 ios_platform_tests_3_4 stable | ||
| recipe: plugins/plugins | ||
| presubmit: false | ||
| bringup: true # New target: https://github.com/flutter/plugins/pull/6682 | ||
| timeout: 30 | ||
| properties: | ||
| channel: stable | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_stable.version | ||
| target_file: mac_ios_platform_tests.yaml | ||
| package_sharding: "--shardIndex 3 --shardCount 4" | ||
|
|
||
| - name: Windows win32-platform_tests master | ||
| recipe: plugins/plugins | ||
| timeout: 30 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
| # Copyright 2013 The Flutter Authors. All rights reserved. | ||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| xcrun simctl list | ||
| xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-16-0 | xargs xcrun simctl boot | ||
|
Contributor
Author
There was a problem hiding this comment. Updated to use iOS-16-0, which is the default runtime with current xcode.
Contributor
There was a problem hiding this comment. Since we have a mini-script, I think it would be nice to pull out the device and OS into variables so each is on their own line instead of one massive line.
Contributor
Author
There was a problem hiding this comment. SG. Updated the script. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| tasks: | ||
| - name: create simulator | ||
| script: .ci/scripts/create_simulator.sh | ||
| - name: build examples | ||
| script: script/tool_runner.sh | ||
| args: ["build-examples", "--ios"] | ||
| - name: xcode analyze | ||
| script: script/tool_runner.sh | ||
| args: ["xcode-analyze", "--ios"] | ||
| - name: xcode analyze deprecation | ||
| # Ensure we don't accidentally introduce deprecated code. | ||
| script: script/tool_runner.sh | ||
| args: ["xcode-analyze", "--ios", "--ios-min-version=13.0"] | ||
| - name: native test | ||
| script: script/tool_runner.sh | ||
| args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=iPhone 11,OS=latest"] | ||
| - name: drive examples | ||
| # `drive-examples` contains integration tests, which changes the UI of the application. | ||
| # This UI change sometimes affects `xctest`. | ||
| # So we run `drive-examples` after `native-test`; changing the order will result ci failure. | ||
| script: script/tool_runner.sh | ||
| args: ["drive-examples", "--ios", "--exclude=script/configs/exclude_integration_ios.yaml"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the clarify of "index" and "count" being in the name, I think it would be clear to 1-index them and add an "of". I.e.,
ios_platform_tests_1_of_4throughios_platform_tests_4_of_4.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.