Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Enable Mac build_all_plugins #6671

Merged
auto-submit merged 7 commits into from
Nov 9, 2022
Merged

Enable Mac build_all_plugins #6671

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
360cd73
general build_all_plugins
keyonghan Nov 4, 2022
a493c06
add separate macos
keyonghan Nov 4, 2022
a6ad527
add arg for windows
keyonghan Nov 4, 2022
bc44a84
add targets
keyonghan Nov 4, 2022
08e05f8
udpate version file
keyonghan Nov 4, 2022
97e3c33
platform & build_mode args
keyonghan Nov 7, 2022
48c1e1d
map docs from cirrus
keyonghan Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,26 @@ targets:
version_file: flutter_master.version
target_file: mac_lint_podspecs.yaml

- name: Mac_x64 build_all_plugins master
recipe: plugins/plugins
bringup: true # New target: https://github.com/flutter/plugins/pull/6671
timeout: 30
properties:
add_recipes_cq: "true"
version_file: flutter_master.version
target_file: mac_build_all_plugins.yaml
channel: master

- name: Mac_x64 build_all_plugins stable
recipe: plugins/plugins
bringup: true # New target: https://github.com/flutter/plugins/pull/6671
timeout: 30
properties:
add_recipes_cq: "true"
version_file: flutter_stable.version
target_file: mac_build_all_plugins.yaml
channel: stable

- name: Windows win32-platform_tests master
recipe: plugins/plugins
timeout: 30
Expand Down
9 changes: 7 additions & 2 deletions .ci/scripts/build_all_plugins.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

arg="$1"
cd all_packages
flutter build windows --debug
flutter build windows --release
if [[ "$arg" == "web" ]]; then

@stuartmorgan-g stuartmorgan-g Nov 7, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is skipping everything on web, rather than just skipping debug.

@keyonghan keyonghan Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! With changes to the other comment, this is resolved and web case will be handled with a comment for the debug mode.

echo "Skipping; web does not support debug builds"
else
flutter build "$arg" --debug
flutter build "$arg" --release

@stuartmorgan-g stuartmorgan-g Nov 7, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although relatedly, I didn't consider this before: in Cirrus I have this as two different script steps because it means that the output for each part is clearly separated in the results UI. That's much more usable than having to scroll through a bunch of output with multiple runs and the failure somewhere in the middle.

I think for LUCI the best option would be to make this take two args, the platform and the build mode, then have the yaml file call it twice, each from a separate task. Then the web logic doesn't need to be here at all, it would just be a comment in a future web_build_all_plugins.yaml about why it's not doing debug like the other platforms.

@keyonghan keyonghan Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Updated to accept those two args.

fi
1 change: 1 addition & 0 deletions .ci/targets/build_all_plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ tasks:
script: .ci/scripts/create_all_plugins_app.sh
- name: build all_plugins
script: .ci/scripts/build_all_plugins.sh
args: ["windows"]

@keyonghan keyonghan Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find an easy way to inject Env. variable to yaml. It would be nice to consolidate different platforms when recipes has a good support on yaml Env. parser. For now, I am using separate .yaml targets for different platforms.

8 changes: 8 additions & 0 deletions .ci/targets/mac_build_all_plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
- name: create all_plugins app
script: .ci/scripts/create_all_plugins_app.sh
- name: build all_plugins
script: .ci/scripts/build_all_plugins.sh
args: ["macos"]