Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Fix typo #6650

Merged
auto-submit merged 4 commits into from
Nov 4, 2022
Merged

[webview_flutter] Fix typo #6650

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39023d8
Update webview.dart
fzyzcjy Nov 2, 2022
d01ba33
Update CHANGELOG.md
fzyzcjy Nov 3, 2022
845c19d
Update CHANGELOG.md
fzyzcjy Nov 3, 2022
7819df7
Merge branch 'flutter:main' into patch-5
fzyzcjy Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/webview_flutter/webview_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Fixes avoid_redundant_argument_values lint warnings and minor typos.
* Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231).
* Updates references to the obsolete master branch.
* Fix typo from lowercase to uppercase

@stuartmorgan-g stuartmorgan-g Nov 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to follow the changelog style guide linked from the PR description.

@fzyzcjy fzyzcjy Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


## 3.0.4

Expand Down
4 changes: 2 additions & 2 deletions packages/webview_flutter/webview_flutter/lib/src/webview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class _WebViewState extends State<WebView> {
webViewPlatformCallbacksHandler: _platformCallbacksHandler,
javascriptChannelRegistry: _javascriptChannelRegistry,
gestureRecognizers: widget.gestureRecognizers,
creationParams: _creationParamsfromWidget(widget),
creationParams: _creationParamsFromWidget(widget),
);
}

Expand Down Expand Up @@ -361,7 +361,7 @@ class _WebViewState extends State<WebView> {
}
}

CreationParams _creationParamsfromWidget(WebView widget) {
CreationParams _creationParamsFromWidget(WebView widget) {
return CreationParams(
initialUrl: widget.initialUrl,
webSettings: _webSettingsFromWidget(widget),
Expand Down