Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Add ProcessCameraProvider class to CameraX plugin#6469

Merged
auto-submit[bot] merged 14 commits into
flutter-team-archive:mainfrom
camsim99:camx_pcp
Sep 27, 2022
Merged

[camera] Add ProcessCameraProvider class to CameraX plugin#6469
auto-submit[bot] merged 14 commits into
flutter-team-archive:mainfrom
camsim99:camx_pcp

Conversation

@camsim99

@camsim99 camsim99 commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#111127.

Also refines CameraInfoFlutterApiImpl to match the create method of other Flutter API Implementations I've implemented thus far.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@camsim99 camsim99 marked this pull request as ready for review September 27, 2022 12:09

@bparrishMines bparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99

Copy link
Copy Markdown
Contributor Author

@bparrishMines I accidentally did not push the test before. I just pushed it if you want to take a quick look before I submit it!

@bparrishMines bparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants