Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix for CameraAccessException that prevents image capture on certain devices running Android 7/8 #4572

Merged
fluttergithubbot merged 12 commits into from
Mar 8, 2022
Merged

[camera] Fix for CameraAccessException that prevents image capture on certain devices running Android 7/8 #4572

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
17bbff0
[camera] Fix for CameraAccessException affecting certain devices on A…
chriscarman-mp Dec 3, 2021
3c5ba8f
Moved stopRepeating outside of if/else and added notes
carman247 Dec 31, 2021
a64449f
Amended note
chriscarman-mp Dec 31, 2021
cfac824
Removed captureSession.abortCaptures from takePictureAfterPrecapture
chriscarman-mp Jan 14, 2022
e34bb03
Merge branch 'main' into camera-fix-camera-access-exception
stuartmorgan-g Jan 14, 2022
819e505
Merge branch 'main' into camera-fix-camera-access-exception
stuartmorgan-g Feb 11, 2022
e07ca93
Add unit test
stuartmorgan-g Feb 11, 2022
e9cc640
Variable name fix
stuartmorgan-g Feb 25, 2022
ab6d254
Merge branch 'main' into camera-fix-camera-access-exception
stuartmorgan-g Feb 25, 2022
181ca3b
Merge branch 'main' into camera-fix-camera-access-exception
stuartmorgan-g Mar 8, 2022
4b7c855
Merge branch 'main' into camera-fix-camera-access-exception
stuartmorgan-g Mar 8, 2022
4cf9537
Update version again
stuartmorgan-g Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.9.4+6

* Fixes bug resulting in a `CameraAccessException` that prevents image capture on certain devices running Android 7/8.

## 0.9.4+5

* Fixes bug where calling a method after the camera was closed resulted in a Java `IllegalStateException` exception.
Expand Down
8 changes: 6 additions & 2 deletions packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,12 @@ public void onCaptureCompleted(
};

try {
captureSession.stopRepeating();
captureSession.abortCaptures();
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.O) {
captureSession.stopRepeating();

@stuartmorgan-g stuartmorgan-g Dec 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line duplicated instead of outside of the if/else?

} else {
captureSession.stopRepeating();
captureSession.abortCaptures();

@stuartmorgan-g stuartmorgan-g Dec 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be a comment explaining why this is conditional.

@subzero911 subzero911 Jan 14, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this line causes troubles on some old Huawei/Xiaomi devices.

}
Log.i(TAG, "sending capture request");
captureSession.capture(stillBuilder.build(), captureCallback, backgroundHandler);
} catch (CameraAccessException e) {
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
Dart.
repository: https://github.com/flutter/plugins/tree/master/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.9.4+5
version: 0.9.4+6

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down