Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] use background script #4349

Merged
stuartmorgan-g merged 3 commits into from
Sep 14, 2021
Merged

[ci] use background script #4349

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42a304d
[ci] use background script
fkorotkov Sep 14, 2021
02dac56
Separate chromedriver script instruction
fkorotkov Sep 14, 2021
6ea4ec4
Added missing "cd"
fkorotkov Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,9 @@ task:
- git clone https://github.com/flutter/web_installers.git
- cd web_installers/packages/web_drivers/
- dart pub get
chromedriver_background_script:
- dart lib/web_driver_installer.dart chromedriver --install-only
- ./chromedriver/chromedriver --port=4444 &
- ./chromedriver/chromedriver --port=4444

@stuartmorgan-g stuartmorgan-g Sep 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want this to be a separate script step that is background, and the rest to stay as-is.

@ditman ditman Sep 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

      install_script:
        - git clone https://github.com/flutter/web_installers.git
        - cd web_installers/packages/web_drivers/
        - dart pub get
        - dart lib/web_driver_installer.dart chromedriver --install-only
      install_background_script:
        - ./chromedriver/chromedriver --port=4444

?

@fkorotkov fkorotkov Sep 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 02dac56

build_script:
- ./script/tool_runner.sh build-examples --web
drive_script:
Expand Down