[image_picker] Fixed IOException when cache directory is removed

packages/image_picker/image_picker/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.8.1+3
+
+* Fix image picker causing a crash when the cache directory is deleted.
+
 ## 0.8.1+2
 
 * Update the example app to support the multi-image feature.

packages/image_picker/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

@@ -401,6 +401,7 @@ private File createTemporaryWritableFile(String suffix) {
     File image;
 
     try {
+      externalFilesDirectory.mkdirs();
       image = File.createTempFile(filename, suffix, externalFilesDirectory);
     } catch (IOException e) {
       throw new RuntimeException(e);

packages/image_picker/image_picker/example/android/app/src/test/java/io/flutter/plugins/imagepicker/ImagePickerDelegateTest.java

@@ -155,11 +155,18 @@ public void takeImageWithCamera_WhenCameraPermissionNotPresent_RequestsForPermis
     when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);
 
     ImagePickerDelegate delegate = createDelegate();
-    delegate.takeImageWithCamera(mockMethodCall, mockResult);
 
-    verify(mockActivity)
-        .startActivityForResult(
-            any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    try (MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class)) {
+      mockStaticFile
+          .when(() -> File.createTempFile(any(), any(), any()))
+          .thenReturn(new File("/tmpfile"));
+
+      delegate.takeImageWithCamera(mockMethodCall, mockResult);
+
+      verify(mockActivity)
+          .startActivityForResult(
+              any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    }
   }
 
   @Test
@@ -169,11 +176,18 @@ public void takeImageWithCamera_WhenCameraPermissionNotPresent_RequestsForPermis
     when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);
 
     ImagePickerDelegate delegate = createDelegate();
-    delegate.takeImageWithCamera(mockMethodCall, mockResult);
 
-    verify(mockActivity)
-        .startActivityForResult(
-            any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    try (MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class)) {
+      mockStaticFile
+          .when(() -> File.createTempFile(any(), any(), any()))
+          .thenReturn(new File("/tmpfile"));
+
+      delegate.takeImageWithCamera(mockMethodCall, mockResult);
+
+      verify(mockActivity)
+          .startActivityForResult(
+              any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    }
   }
 
   @Test
@@ -195,17 +209,18 @@ public void takeImageWithCamera_WritesImageToCacheDirectory() {
     when(mockPermissionManager.isPermissionGranted(Manifest.permission.CAMERA)).thenReturn(true);
     when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);
 
-    MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class);
-    mockStaticFile
-        .when(() -> File.createTempFile(any(), any(), any()))
-        .thenReturn(new File("/tmpfile"));
+    try (MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class)) {
+      mockStaticFile
+          .when(() -> File.createTempFile(any(), any(), any()))
+          .thenReturn(new File("/tmpfile"));
 
-    ImagePickerDelegate delegate = createDelegate();
-    delegate.takeImageWithCamera(mockMethodCall, mockResult);
+      ImagePickerDelegate delegate = createDelegate();
+      delegate.takeImageWithCamera(mockMethodCall, mockResult);
 
-    mockStaticFile.verify(
-        () -> File.createTempFile(any(), eq(".jpg"), eq(new File("/image_picker_cache"))),
-        times(1));
+      mockStaticFile.verify(
+          () -> File.createTempFile(any(), eq(".jpg"), eq(new File("/image_picker_cache"))),
+          times(1));
+    }
   }
 
   @Test
@@ -225,32 +240,44 @@ public void onRequestPermissionsResult_WhenCameraPermissionDenied_FinishesWithEr
   public void
       onRequestTakeVideoPermissionsResult_WhenCameraPermissionGranted_LaunchesTakeVideoWithCameraIntent() {
     when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);
-
     ImagePickerDelegate delegate = createDelegateWithPendingResultAndMethodCall();
-    delegate.onRequestPermissionsResult(
-        ImagePickerDelegate.REQUEST_CAMERA_VIDEO_PERMISSION,
-        new String[] {Manifest.permission.CAMERA},
-        new int[] {PackageManager.PERMISSION_GRANTED});
 
-    verify(mockActivity)
-        .startActivityForResult(
-            any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_VIDEO_WITH_CAMERA));
+    try (MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class)) {
+      mockStaticFile
+          .when(() -> File.createTempFile(any(), any(), any()))
+          .thenReturn(new File("/tmpfile"));
+
+      delegate.onRequestPermissionsResult(
+          ImagePickerDelegate.REQUEST_CAMERA_VIDEO_PERMISSION,
+          new String[] {Manifest.permission.CAMERA},
+          new int[] {PackageManager.PERMISSION_GRANTED});
+
+      verify(mockActivity)
+          .startActivityForResult(
+              any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_VIDEO_WITH_CAMERA));
+    }
   }
 
   @Test
   public void
       onRequestTakeImagePermissionsResult_WhenCameraPermissionGranted_LaunchesTakeWithCameraIntent() {
     when(mockIntentResolver.resolveActivity(any(Intent.class))).thenReturn(true);
-
     ImagePickerDelegate delegate = createDelegateWithPendingResultAndMethodCall();
-    delegate.onRequestPermissionsResult(
-        ImagePickerDelegate.REQUEST_CAMERA_IMAGE_PERMISSION,
-        new String[] {Manifest.permission.CAMERA},
-        new int[] {PackageManager.PERMISSION_GRANTED});
 
-    verify(mockActivity)
-        .startActivityForResult(
-            any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    try (MockedStatic<File> mockStaticFile = Mockito.mockStatic(File.class)) {
+      mockStaticFile
+          .when(() -> File.createTempFile(any(), any(), any()))
+          .thenReturn(new File("/tmpfile"));
+
+      delegate.onRequestPermissionsResult(
+          ImagePickerDelegate.REQUEST_CAMERA_IMAGE_PERMISSION,
+          new String[] {Manifest.permission.CAMERA},
+          new int[] {PackageManager.PERMISSION_GRANTED});
+
+      verify(mockActivity)
+          .startActivityForResult(
+              any(Intent.class), eq(ImagePickerDelegate.REQUEST_CODE_TAKE_IMAGE_WITH_CAMERA));
+    }
   }
 
   @Test
@@ -380,7 +407,7 @@ private ImagePickerDelegate createDelegate() {
   private ImagePickerDelegate createDelegateWithPendingResultAndMethodCall() {
     return new ImagePickerDelegate(
         mockActivity,
-        null,
+        new File("/image_picker_cache"),
         mockImageResizer,
         mockResult,
         mockMethodCall,

packages/image_picker/image_picker/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for selecting images from the Android and iOS image
   library, and taking new pictures with the camera.
 repository: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
-version: 0.8.1+2
+version: 0.8.1+3
 
 environment:
   sdk: ">=2.12.0 <3.0.0"