This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Skip pod lint tests#3692
Merged
Merged
Conversation
Contributor
|
This'll have to be merged on red to cure the tree. I can babysit this. |
Contributor
Author
|
\cc @cyanglaz |
Contributor
Looking great so far! Thanks again @jmagman! |
Contributor
|
Both |
Contributor
Author
Safe to land this then to green out the build since that's all it touched. Thanks @ditman! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 9, 2021
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Mar 18, 2021
* master: (49 commits) Prep for alignment with Flutter analysis options (flutter-team-archive#3703) [google_maps_flutter_platform_interface] Mark constructors as const for ids (flutter-team-archive#3718) [image_picker] Endorse image_picker_for_web (flutter-team-archive#3717) Add missing licenses, and add a check (flutter-team-archive#3720) [ci] Add libgcrypt to Docker image. (flutter-team-archive#3711) Reorder the checkboxes in the PR template (flutter-team-archive#3666) Re-endorse connectivity_for_web (flutter-team-archive#3708) Fix missing declaration of windows' default_package (flutter-team-archive#3705) Typos in comments (flutter-team-archive#2846) Skip flutter upgrade for pod linting Cirrus task (flutter-team-archive#3700) [cross_file] Delete. (flutter-team-archive#3698) [tool] Improve check version ci so that it enforces the version in CHANGELOG and pubspec matches. (flutter-team-archive#3678) Streamline CI setup, and reenable macOS credits (flutter-team-archive#3697) [video_player] fixed misleading size and aspect ratio documentation (flutter-team-archive#3668) [image_picker] Implemented 2860 and added Unit Test to test functionality (flutter-team-archive#3685) [shared_preferences] Fix concurrent modification of the shared preferences on Android (flutter-team-archive#3684) [extension_google_sign_in_as_googleapis_auth] Deleted. (flutter-team-archive#3694) Skip pod lint tests (flutter-team-archive#3692) [Video_Player] Remove the deprecated API reference. (flutter-team-archive#3669) [google_sign_in] fix test(flutter-team-archive#3690) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
xctestcommand runs thewebview_flutter#3664 andimage_picker#3663 unit tests, skip them in thepod lib linttest to avoid doubling the work.See #3667
Fixes flutter/flutter#77661 (well, avoids it entirely).