Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add a note about Plus plugins to CONTRIBUTING.md #3511

Merged
stuartmorgan-g merged 4 commits into from
Feb 4, 2021
Merged

Add a note about Plus plugins to CONTRIBUTING.md #3511

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5b8173
Add a note about Plus plugins to CONTRIBUTING.md
stuartmorgan-g Feb 4, 2021
cc2707a
Clarify "critical"
stuartmorgan-g Feb 4, 2021
87a105f
Fix plugin order
stuartmorgan-g Feb 4, 2021
34f76cf
Reword
stuartmorgan-g Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,25 @@

_See also: [Flutter's code of conduct](https://github.com/flutter/flutter/blob/master/CODE_OF_CONDUCT.md)_

## Important note

As of January 2021, we are no longer accepting non-critical PRs for plugins
Comment thread
stuartmorgan-g marked this conversation as resolved.
for which there is a corresponding [Flutter Community Plus
Plugin](https://plus.fluttercommunity.dev/), as we hope that in time we're able

@csells csells Feb 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"as we hope in time to be able"

@stuartmorgan-g stuartmorgan-g Feb 4, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done. Also made the same change in the snippet we're using to close PRs, since this was copied directly from there for consistency.

I'll also be sure to pass along your feedback to the original author of that snippet ;)

@csells csells Feb 4, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I'm sure they'll appreciate the feedback. : )

to transition users to those versions of the plugins. If you have a PR for
something other than a critical issue (crashes, build failures, null safety, etc.)
for any of the following plugins, we encourage you to submit it
[there](https://github.com/fluttercommunity/plus_plugins/pulls) instead:
- `android_alarm_manager`
- `android_intent`
- `battery`
- `connectivity`
- `device_info`
- `package_info`
- `sensors`
- `share`
- `wifi_info_flutter` (corresponds to `network_info_plus`)

## Things you will need


Expand Down