[in_app_purchase] Fix app exceptions caused by missing App Store receipt

packages/in_app_purchase/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.3.4+2
+* iOS: Fix treating missing App Store receipt as an exception.
+
 ## 0.3.4+1
 
 * iOS: Fix the bug that `SKPaymentQueueWrapper.transactions` doesn't return all transactions.

packages/in_app_purchase/ios/Classes/FIAPReceiptManager.m

@@ -16,18 +16,21 @@ @implementation FIAPReceiptManager
 
 - (NSString *)retrieveReceiptWithError:(FlutterError **)error {
   NSURL *receiptURL = [[NSBundle mainBundle] appStoreReceiptURL];
-  NSData *receipt = [self getReceiptData:receiptURL];
+  NSError *err;
+  NSData *receipt = [self getReceiptData:receiptURL error:&err];
   if (!receipt) {
-    *error = [FlutterError errorWithCode:@"storekit_no_receipt"
-                                 message:@"Cannot find receipt for the current main bundle."
-                                 details:nil];
+    return nil;
+  }
+  if (error) {
+    *error = [FlutterError errorWithCode:[[NSString alloc] initWithFormat:@"%li", err.code];
+                                 message:error.domain details:err.userInfo];
     return nil;
   }
   return [receipt base64EncodedStringWithOptions:kNilOptions];
 }
 
-- (NSData *)getReceiptData:(NSURL *)url {
-  return [NSData dataWithContentsOfURL:url];
+- (NSData *)getReceiptData:(NSURL *)url error:(NSError **)error {
+  return [NSData dataWithContentsOfURL:url options:NSDataReadingMappedIfSafe error:error];
 }
 
 @end

packages/in_app_purchase/lib/src/store_kit_wrappers/sk_receipt_manager.dart

@@ -14,8 +14,12 @@ class SKReceiptManager {
   /// There are 2 ways to do so. Either validate locally or validate with App Store.
   /// For more details on how to validate the receipt data, you can refer to Apple's document about [`About Receipt Validation`](https://developer.apple.com/library/archive/releasenotes/General/ValidateAppStoreReceipt/Introduction.html#//apple_ref/doc/uid/TP40010573-CH105-SW1).
   /// If the receipt is invalid or missing, you can use [SKRequestMaker.startRefreshReceiptRequest] to request a new receipt.
-  static Future<String> retrieveReceiptData() {
-    return channel.invokeMethod<String>(
-        '-[InAppPurchasePlugin retrieveReceiptData:result:]');
+  static Future<String> retrieveReceiptData() async {
+    try {
+      return await channel.invokeMethod<String>(
+          '-[InAppPurchasePlugin retrieveReceiptData:result:]');
+    } catch (_) {
+      rethrow;
+    }
   }
 }

packages/in_app_purchase/pubspec.yaml

@@ -1,7 +1,7 @@
 name: in_app_purchase
 description: A Flutter plugin for in-app purchases. Exposes APIs for making in-app purchases through the App Store and Google Play.
 homepage: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase
-version: 0.3.4+1
+version: 0.3.4+2
 
 dependencies:
   async: ^2.0.8

packages/in_app_purchase/test/store_kit_wrappers/sk_methodchannel_apis_test.dart

@@ -6,6 +6,7 @@ import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:in_app_purchase/src/channel.dart';
 import 'package:in_app_purchase/store_kit_wrappers.dart';
+import 'package:test/test.dart' show TypeMatcher;
 import 'sk_test_stub_objects.dart';
 
 void main() {
@@ -76,6 +77,12 @@ void main() {
       String receiptData = await SKReceiptManager.retrieveReceiptData();
       expect(receiptData, 'receipt data');
     });
+
+    test('should get null receipt if any exceptions are raised', () async {
+      fakeIOSPlatform.getReceiptFailTest = true;
+      expect(() async => SKReceiptManager.retrieveReceiptData(),
+          throwsA(TypeMatcher<PlatformException>()));
+    });
   });
 
   group('sk_payment_queue', () {
@@ -128,11 +135,15 @@ class FakeIOSPlatform {
   FakeIOSPlatform() {
     channel.setMockMethodCallHandler(onMethodCall);
     getProductRequestFailTest = false;
+    getReceiptFailTest = false;
   }
   // get product request
   List startProductRequestParam;
   bool getProductRequestFailTest;
 
+  // get receipt request
+  bool getReceiptFailTest;
+
   // refresh receipt request
   int refreshReceipt = 0;
   Map refreshReceiptParam;
@@ -161,6 +172,9 @@ class FakeIOSPlatform {
         return Future<void>.sync(() {});
       // receipt manager
       case '-[InAppPurchasePlugin retrieveReceiptData:result:]':
+        if (getReceiptFailTest) {
+          throw ("some arbitrary error");
+        }
         return Future<String>.value('receipt data');
       // payment queue
       case '-[SKPaymentQueue canMakePayments:]':