Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[cleanup] Remove AndroidX warning#2231

Merged
blasten merged 2 commits into
flutter-team-archive:masterfrom
blasten:remove_androidx_warning
Oct 28, 2019
Merged

[cleanup] Remove AndroidX warning#2231
blasten merged 2 commits into
flutter-team-archive:masterfrom
blasten:remove_androidx_warning

Conversation

@blasten

@blasten blasten commented Oct 23, 2019

Copy link
Copy Markdown

Remove AndroidX warnings since now the tool provides warnings.

@blasten blasten requested a review from mklim October 23, 2019 20:05

@mklim mklim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle changes LG, but all these plugins also need their pubspec.yaml and CHANGELOG updated.

It may be easier to deal with the patch if the changes were split per-plugin, but the deletion here is so straightforward that I don't think it's really necessary.

@blasten blasten force-pushed the remove_androidx_warning branch from 12d54d9 to c89ab59 Compare October 26, 2019 05:33
@blasten blasten merged commit 8160f31 into flutter-team-archive:master Oct 28, 2019
@blasten blasten deleted the remove_androidx_warning branch October 28, 2019 19:04
@bparrishMines

Copy link
Copy Markdown
Contributor

@blasten @mklim Should we be doing this in the flutterfire repo too?

@blasten

blasten commented Oct 29, 2019

Copy link
Copy Markdown
Author

@bparrishMines 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants