This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[path_provider] Android: Support multiple external storage options #2049
Merged
cyanglaz
merged 43 commits into
flutter-team-archive:master
from
ened:path-provider-android
Oct 21, 2019
Merged
Changes from 23 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
f9bca2b
Add support for Android devices with multiple external storage options.
ened 6414953
Merge branch 'master' into path-provider-android
e5fe50b
Update path_provider AGB & iOS project file
8c5b266
extend unit tests for new methods
8803465
[path_provider] Activate getApplicationSupportDirectory integration test
ecc8aca
Merge branch 'path_provider/integration_test' into path-provider-android
280f229
add integration tests
2a3e4d4
[path_provider] Activate getApplicationSupportDirectory integration test
d6f66f2
Merge branch 'path_provider/integration_test' into path-provider-android
72a943b
Add missing unit tests
b4459b3
Merge branch 'path_provider/integration_test' into path-provider-android
7323e37
Formatting
1cfb256
Merge branch 'path_provider/integration_test' into path-provider-android
2736545
Merge branch 'master' of https://github.com/flutter/plugins into path…
e05e869
Merge branch 'master' into path-provider-android
e577e50
Merge branch 'master' of https://github.com/flutter/plugins into path…
f2941d9
Merge branch 'master' of https://github.com/flutter/plugins into path…
cf475e1
[path_provider] Updates tests and copy Android environment names.
354c9fa
Bump version
b60142f
Revert unrelated PR changes.
1b5f73a
Resolve test issues introduced in #1953.
d08d778
Formatting.
11620f0
Remove unused import
6ce45b1
Merge branch 'master' into path-provider-android
ened e8c948b
{} nits and ' strings
ened a175402
Introduce a enum to specify the storage directory
ened 30465c3
Refactor test driver and remove now unused uuid dependency.
ened b3c78db
Missing doc nit
ened 499fbdb
dartfmt
ened 321c331
add missing storage directory types
ened d368c80
dartfmt once more
ened 9806d05
Merge branch 'master' into path-provider-android
ened 8937f5d
Merge branch 'master' of https://github.com/flutter/plugins into path…
ened abf34d6
Activate JUnit
ened 3d96cc9
Pass a dart enum (by index) directly to Android, update tests.
ened b7d4b58
Add unit tests for the storage directory enum.
ened 30f49ab
nit
ened 7c1be07
Formatting.
ened c8d7572
Formatting.
ened 408a3bb
Merge branch 'master' into path-provider-android
ened 4e9a465
Merge branch 'master' into path-provider-android
ened 76029b6
add clear exception when documents directory is unsupported
ened bc55bb2
Bump to V1.4.0 due to public API changes
ened File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyanglaz I have followed the style in the current example code, but think the indentation could be shown better with a few additional "," here & there. Perhaps better to be added in a future PR?