Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Calling destroy on webview when flutter part is getting disposed #1886

Merged
amirh merged 8 commits into from
Aug 15, 2019
Merged

[webview_flutter] Calling destroy on webview when flutter part is getting disposed #1886

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3f4b68
Calling destroy on webview when flutter part is getting disposed
charafau Jul 20, 2019
ac1d168
Merge branch 'master' into android_destroy_on_dispose
charafau Jul 21, 2019
83aad91
upgraded changelog and pubspec version
charafau Jul 21, 2019
0e89f45
fixed changelog
charafau Jul 21, 2019
f9cd164
fixed changelog
charafau Jul 23, 2019
2ce514e
rebased with master
charafau Aug 5, 2019
0e40d87
Merge branch 'master' into android_destroy_on_dispose
charafau Aug 15, 2019
8a65fac
fix changelog
amirh Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/webview_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## 0.3.10+3
## 0.3.10+4

* Don't log an unknown setting key error for 'debuggingEnabled' on iOS.

@Liangdi Liangdi Jul 21, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wrong logs

@charafau charafau Jul 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing, I missed that after rebasing with master.

@amirh amirh Jul 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

@charafau charafau Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about confusion with changelog. I added * to that.


## 0.3.10+3

Don't log an unknown setting key error for 'debuggingEnabled' on iOS.

## 0.3.10+2

* Fix InputConnection being lost when combined with route transitions.
Expand Down
1 change: 1 addition & 0 deletions ...bview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,6 @@ private void registerJavaScriptChannelNames(List<String> channelNames) {
public void dispose() {
methodChannel.setMethodCallHandler(null);
webView.dispose();
webView.destroy();
}
}
2 changes: 1 addition & 1 deletion packages/webview_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: webview_flutter
description: A Flutter plugin that provides a WebView widget on Android and iOS.
version: 0.3.10+3
version: 0.3.10+4
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/webview_flutter

Expand Down