This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[google_maps_flutter] Breaking change fix for bitmap scaling #1821
Merged
cyanglaz
merged 21 commits into
flutter-team-archive:master
from
duzenko:maps-scaling-bitmap-fix
Mar 20, 2020
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f9597ec
Allow BitmapDescriptor scaling override
duzenko 74e4333
Merge commit '1e01c9e12d564642735e1a7308a21083b9769b11' into maps-sca…
duzenko c7beecf
Merge remote-tracking branch 'upstream/master' into maps-scaling-bitmap
duzenko 9cf14ff
Updated the pubspec.yml and changelog files
duzenko 4c12b6a
Breaking change fix
duzenko 3a1378b
Merge commit '4c12b6a4dd2ad973c97679fa8d1821a901ef2d6f' into maps-sca…
duzenko aeb52b2
Merge remote-tracking branch 'upstream/master' into maps-scaling-bitm…
duzenko 78edc73
Failing test for BitmapDescriptor.fromAssetImage
duzenko 2fa20d6
Version bump in change log
duzenko 5cb40bd
Update packages/google_maps_flutter/pubspec.yaml
duzenko a000e0b
cyanglaz's suggstions
duzenko 5b453bb
Update bitmap.dart
b613631
merge master
7142174
remove extra line
7fe0eda
Update FLTConnectivityPlugin.m
f0c7589
revert accidental format change
c14cdef
Merge branch 'maps-scaling-bitmap-fix' of github.com:duzenko/plugins …
e15039c
fix analyze error
85d1979
fix analyze error
6cf6c29
fix tests
d5c211f
Update CHANGELOG.md
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duzenko forgot to ask, what is this test testing for? It seems to print stuff but never actually test anything?
This comment has been minimized.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks. Do you want to try to make it work? I have resolved all the conflicts in this PR, it should be easier to work with now.