Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Breaking change fix for bitmap scaling #1821

Merged
cyanglaz merged 21 commits into from
Mar 20, 2020
Merged

[google_maps_flutter] Breaking change fix for bitmap scaling #1821

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f9597ec
Allow BitmapDescriptor scaling override
duzenko Jun 12, 2019
74e4333
Merge commit '1e01c9e12d564642735e1a7308a21083b9769b11' into maps-sca…
duzenko Jun 13, 2019
c7beecf
Merge remote-tracking branch 'upstream/master' into maps-scaling-bitmap
duzenko Jun 20, 2019
9cf14ff
Updated the pubspec.yml and changelog files
duzenko Jun 20, 2019
4c12b6a
Breaking change fix
duzenko Jul 9, 2019
3a1378b
Merge commit '4c12b6a4dd2ad973c97679fa8d1821a901ef2d6f' into maps-sca…
duzenko Jul 9, 2019
aeb52b2
Merge remote-tracking branch 'upstream/master' into maps-scaling-bitm…
duzenko Jul 15, 2019
78edc73
Failing test for BitmapDescriptor.fromAssetImage
duzenko Jul 16, 2019
2fa20d6
Version bump in change log
duzenko Feb 24, 2020
5cb40bd
Update packages/google_maps_flutter/pubspec.yaml
duzenko Mar 10, 2020
a000e0b
cyanglaz's suggstions
duzenko Mar 10, 2020
5b453bb
Update bitmap.dart
Mar 10, 2020
b613631
merge master
Mar 10, 2020
7142174
remove extra line
Mar 10, 2020
7fe0eda
Update FLTConnectivityPlugin.m
Mar 10, 2020
f0c7589
revert accidental format change
Mar 10, 2020
c14cdef
Merge branch 'maps-scaling-bitmap-fix' of github.com:duzenko/plugins …
Mar 10, 2020
e15039c
fix analyze error
Mar 10, 2020
85d1979
fix analyze error
Mar 10, 2020
6cf6c29
fix tests
Mar 18, 2020
d5c211f
Update CHANGELOG.md
Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.21

* Breaking change fix for BitmapDescriptor scaling override

@cyanglaz cyanglaz Feb 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an optional param mipmaps for BitmapDescriptor. fromAssetImage .


## 0.5.20

* Add map toolbar support
Expand Down
16 changes: 16 additions & 0 deletions packages/google_maps_flutter/example/test_driver/google_maps.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,4 +539,20 @@ void main() {
final GoogleMapController controller = await controllerCompleter.future;
await controller.setMapStyle(null);
});

test("fromAssetImage", () async {
final Iterable<Future<bool>> futures = <double>[1, 2, 3].map((double pixelRatio) async {
final ImageConfiguration imageConfiguration =
ImageConfiguration(devicePixelRatio: pixelRatio);
final BitmapDescriptor mip = await BitmapDescriptor.fromAssetImage(
imageConfiguration, 'red_square.png');
final BitmapDescriptor scaled = await BitmapDescriptor.fromAssetImage(
imageConfiguration, 'red_square.png', mipmaps: false);
mip.toJson().forEach((dynamic x)=>print(x));
scaled.toJson().forEach((dynamic x)=>print(x));
return Future<bool>.value(true);
});

Future.wait(futures);
});
}
6 changes: 5 additions & 1 deletion packages/google_maps_flutter/lib/src/bitmap.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ class BitmapDescriptor {
String assetName, {
AssetBundle bundle,
String package,
bool mipmaps = true,

@cyanglaz cyanglaz Feb 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make it a non-breaking change by defaulting the mipmaps to false?

This comment has been minimized.

Sign in to view

@cyanglaz cyanglaz Feb 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the ecosystem might have already adopted the last change, compares to the latest code base, setting mipmaps to true would be a breaking change, right?

@cyanglaz cyanglaz Feb 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add dart doc to explain this param.

This comment has been minimized.

Sign in to view

@cyanglaz cyanglaz Feb 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like:
///
/// Set mipmaps to ... to allow ...., mipmaps is ... by default.

}) async {
if (configuration.devicePixelRatio != null) {
if (!mipmaps && configuration.devicePixelRatio != null) {

@cyanglaz cyanglaz Feb 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!mipmaps would be false by default and we changed the behavior here right? I think you meant to set mipmaps to false by default?

This comment has been minimized.

Sign in to view

return BitmapDescriptor._(<dynamic>[
'fromAssetImage',
assetName,
Expand All @@ -85,5 +86,8 @@ class BitmapDescriptor {

final dynamic _json;

@visibleForTesting
dynamic toJson() => _json;

dynamic _toJson() => _json;
}
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter
version: 0.5.20
version: 0.5.20+1
Comment thread
duzenko marked this conversation as resolved.
Outdated

dependencies:
flutter:
Expand Down