Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] [iOS] Fixed a memory leak in the video player plugin. #1660

Merged
cyanglaz merged 13 commits into from
Jul 29, 2019
Merged

[video_player] [iOS] Fixed a memory leak in the video player plugin. #1660

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6c5c142
[video_player] [iOS] Fixed a memory leak in the video player plugin.
shihchanghsiungsonos May 30, 2019
fb7fb82
Fix format issue
shihchanghsiungsonos May 30, 2019
ef51441
Merge branch 'master' of github.com:flutter/plugins into pull-request-2
shihchanghsiungsonos Jul 15, 2019
c7bfc2d
Merge branch 'master' of github.com:flutter/plugins into pull-request-2
shihchanghsiungsonos Jul 15, 2019
e822967
[video_player] [iOS] Fixed a memory leak in the video player plugin.
shihchanghsiungsonos Jul 15, 2019
cbc1d45
Merge branch 'master' of github.com:flutter/plugins into pull-request-2
shihchanghsiungsonos Jul 15, 2019
16bd875
[video_player] [iOS] Fixed a memory leak in the video player plugin.
shihchanghsiungsonos Jul 15, 2019
348014c
Merge branch 'master' of github.com:flutter/plugins into pull-request-2
shihchanghsiungsonos Jul 16, 2019
7049698
bump version to 0.10.1+5
shihchanghsiungsonos Jul 16, 2019
bbf5440
Merge branch 'master' of github.com:flutter/plugins into pull-request-2
shihchanghsiungsonos Jul 16, 2019
a9df1ae
Update with cyanglaz's feedback
shihchanghsiungsonos Jul 16, 2019
029be7d
Merge branch 'master' into pull-request-2
Jul 29, 2019
01e04c7
Update pubspec.yaml
Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.1+5

* [iOS] Fixed a memory leak in the video player plugin.

@cyanglaz cyanglaz Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [iOS] Fixed a memory leak in the video player plugin.
* [iOS] Fixed a memory leak with notification observing.


## 0.10.1+4

* Fixed syntax error in README.md.
Expand Down
31 changes: 17 additions & 14 deletions packages/video_player/ios/Classes/VideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,23 @@ - (void)addObservers:(AVPlayerItem*)item {
options:NSKeyValueObservingOptionInitial | NSKeyValueObservingOptionNew
context:playbackBufferFullContext];

[[NSNotificationCenter defaultCenter] addObserverForName:AVPlayerItemDidPlayToEndTimeNotification
object:[_player currentItem]
queue:[NSOperationQueue mainQueue]
usingBlock:^(NSNotification* note) {
if (self->_isLooping) {
AVPlayerItem* p = [note object];
[p seekToTime:kCMTimeZero
completionHandler:nil];
} else {
if (self->_eventSink) {
self->_eventSink(@{@"event" : @"completed"});
}
}
}];
// Add an observer that will respond to itemDidPlayToEndTime
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(itemDidPlayToEndTime:)
name:AVPlayerItemDidPlayToEndTimeNotification
object:item];
}

- (void)itemDidPlayToEndTime:(NSNotification*)note {

@cyanglaz cyanglaz Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: renaming note -> notification

@shihchanghsiungsonos shihchanghsiungsonos Jul 16, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

AVPlayerItem* p = [note object];
if (self->_isLooping) {

@cyanglaz cyanglaz Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: Same as below for _eventSink

Suggested change
if (self->_isLooping) {
if (_isLooping) {

@shihchanghsiungsonos shihchanghsiungsonos Jul 16, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update. Thanks for the feedback!

AVPlayerItem* p = [note object];
[p seekToTime:kCMTimeZero completionHandler:nil];
} else {
if (self->_eventSink) {
self->_eventSink(@{@"event" : @"completed"});
}
}
}

static inline CGFloat radiansToDegrees(CGFloat radians) {
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player
description: Flutter plugin for displaying inline video with other Flutter
widgets on Android and iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
version: 0.10.1+4
version: 0.10.1+5
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player

flutter:
Expand Down