This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Firebase database query and persistence improvements#144
Merged
collinjackson merged 6 commits intoJun 20, 2017
Conversation
collinjackson
force-pushed
the
persistence_2
branch
from
76e0df8 to
646147a
Compare
collinjackson
force-pushed
the
persistence_2
branch
from
646147a to
87749aa
Compare
collinjackson
force-pushed
the
persistence_2
branch
from
87749aa to
e4a4386
Compare
collinjackson
requested review from
mravn-google
and removed request for
mravn-google
jakobr-google
approved these changes
Jun 20, 2017
| /// | ||
| /// This property must be set before calling methods on database references | ||
| /// and only needs to be called once per application. The returned `Future` | ||
| /// will complete with `true` if the operation was successful or `false` if |
Contributor
There was a problem hiding this comment.
[Future] instead of Future?
| /// Generate a view of the data sorted by values of a particular child key. | ||
| /// | ||
| /// Intended to be used in combination with startAt(), endAt(), or equalTo(). | ||
| /// Intended to be used in combination with [startAt()], [endAt()], or |
Contributor
There was a problem hiding this comment.
I don't think you need the () to refer to methods.
Contributor
Author
|
@goderbauer I'll probably land this before you land #141 so you'll have to update the firebase_database version in your PR |
goderbauer
approved these changes
Jun 20, 2017
goderbauer
left a comment
goderbauer
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I'll update the other PR accordingly.
collinjackson
force-pushed
the
persistence_2
branch
2 times, most recently
from
0ad4479 to
2c85344
Compare
HansMuller
pushed a commit
to HansMuller/plugins
that referenced
this pull request
Jun 30, 2017
…chive#144) ## 0.0.8 * Added missing offline persistence and query functionality on Android * Fixed startAt query behavior on iOS * Persistence methods no longer throw errors on failure, return false instead * Updates to docs and tests
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…chive#144) ## 0.0.8 * Added missing offline persistence and query functionality on Android * Fixed startAt query behavior on iOS * Persistence methods no longer throw errors on failure, return false instead * Updates to docs and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#10821, flutter/flutter#10822, flutter/flutter#10823