This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[camera] Pause/resume video recording for Android & iOS #1370
Merged
bparrishMines
merged 21 commits into
flutter-team-archive:master
from
huulbaek:pauseresume
Aug 19, 2019
Merged
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2971c85
Pause/resume video recording for Android
huulbaek 3e87cac
Specify type
bparrishMines d99f9d0
Merge branch 'master' of github.com:flutter/plugins into huulbaek/pau…
bparrishMines 474604d
Merge branch 'master' of github.com:flutter/plugins into huulbaek/pau…
bparrishMines 423adcd
Add pausing and resuming to example app
bparrishMines 0214093
iOS side of pausing/resuming
bparrishMines 7216d4a
Merge branch 'master' of github.com:flutter/plugins into huulbaek/pau…
bparrishMines 113cd55
More documentation
bparrishMines 5664547
Version bump
bparrishMines 9210c26
Merge branch 'master' of github.com:flutter/plugins into huulbaek/pau…
bparrishMines 3f47c60
Add video pausing and resuming
bparrishMines 5baee78
get pausing and recording to work for no audio
bparrishMines da26df1
It works
bparrishMines b56d1fb
Merge branch 'pauseresume' of github.com:huulbaek/plugins into huulba…
bparrishMines 542ee3d
Formatting
bparrishMines 5023773
Add test for pausing and resuming
bparrishMines 6dbbf8d
Merge branch 'master' into pauseresume
bparrishMines ca47f38
Call success outside try catch block
bparrishMines c758b26
formatting
bparrishMines 70e1b13
Merge branch 'pauseresume' of github.com:huulbaek/plugins into huulba…
bparrishMines 8ff306f
Disable audio in test and call result on iOS
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This should be outside of the
tryblock here and below, just in the weird offhand chance calling this throws anIllegalStateException. If it didresult.errorwould also throw in thecatchblock.