This repository was archived by the owner on Apr 29, 2022. It is now read-only.
Move static methods to anonymous namespace - #137
Merged
Conversation
Contributor
Author
|
I manually verified that when building this locally with Xcode and bitcode enabled, the symbols are exposed before this change and not exposed after. |
zanderso
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes symbol exposure that resulted in revert in flutter-team-archive/engine#32677
Apple Clang doesn't hide these even though Fuchsia Clang does.
The diff is confusing because I re-arranged some code, but this did not actually delete any lines.