Fix enum typedef for older mac SDKs#136
Conversation
| // machines with lower SDK versions than 11.0.s | ||
| #if !defined(MAC_OS_X_VERSION_11_0) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_11_0 | ||
| typedef enum MTLCommandEncoderErrorState : NSInteger { | ||
| #if !defined(MAC_OS_VERSION_11_0) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_11_0 |
There was a problem hiding this comment.
All Mac engine builders except for the Mac Web Engine are running Xcode 13 (which has MAC_OS_VERSION_11_0 defined)
https://github.com/flutter/engine/blob/289368cadccbce88913b3ab279ed754d705740f9/.ci.yaml#L73
Mac Web Engine Xcode migration blocked on flutter/flutter#99885
https://github.com/flutter/engine/blob/289368cadccbce88913b3ab279ed754d705740f9/.ci.yaml#L327
There was a problem hiding this comment.
Need a guard for the macOS 12 defines too
There was a problem hiding this comment.
So once Mac Web engine rolls we can remove the first block here - we won't be able to remove the second until we further upgrade.
|
With this patch applied all impeller related failures on flutter-team-archive/engine#32658 are resolved. |
3 participants
I .. I forget how to write ObjC.
I'm going to let CI finish on flutter-team-archive/engine#32658 (which currently points to my fork) before landing this.