This repository was archived by the owner on Apr 19, 2026. It is now read-only.
[web] Screenshots for fixing ginormous paragraph styles#157
Merged
Conversation
ferhatb
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots for PR: flutter-team-archive/engine#24159
That PR causes the
draw_text_composite_order_belowscreenshot to fail. It adds a tiny gap between the characters and lines of text, similar to the iOS screenshot:It's not clear why that's happening and it's hard to tell by looking at a screenshot with Ahem font. So I changed the font in this screenshot to Roboto, and that showed no difference before the PR and after the PR.
I also made the bounds of the screenshots smaller.