Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add libglfw3-dev to linux build deps script#9993

Closed
cbracken wants to merge 1 commit into
flutter-team-archive:masterfrom
cbracken:glfw-install
Closed

Add libglfw3-dev to linux build deps script#9993
cbracken wants to merge 1 commit into
flutter-team-archive:masterfrom
cbracken:glfw-install

Conversation

@cbracken

Copy link
Copy Markdown
Contributor

This ensures that the OpenGL headers and GLFW are installed.

This ensures that the OpenGL headers and GLFW are installed.
@stuartmorgan-g

Copy link
Copy Markdown
Contributor

What's the context for this change? We build GLFW from source in third_party, so there shouldn't be any dependency on system GLFW headers.

@cloudwebrtc

cloudwebrtc commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

The #9822 needs to use glad, but libglfw3-dev does not seem to have built-in glad.h, glad source exists in third_party\glfw.

@stuartmorgan-g

Copy link
Copy Markdown
Contributor

libglfw3-dev does not seem to have built-in glad.h

Glad isn't conceptually part of GLFW, so there's no reason it should. The deps folder in GLFW where it lives contains external code, like Flutter's third_party.

I'm not sure how that relates to this PR though.

@cloudwebrtc

Copy link
Copy Markdown
Contributor

If this PR is to replace the third_party/glfw dependency with libglfw3-dev, we need to import another glad.h/.c to support the texture, maybe third_party/glad or add to shell/platform/glfw?
Before that I submitted a PR to flutter-team-archive/buildroot#275

@cbracken

cbracken commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

Nope - the issue was that my laptop blew up and I picked up a loaner. It couldn't find some GL (not GLFW) headers until I installed glfw and I expect they showed up in libmesa1-dev or some similar transitive dep. Thinking about it though, I'd have thought we should be pulling that from the buildtools sysroot and not the system, so I wonder if we're not as hermetic as we should be somewhere. Will re-remove the installed packages and see if I can track it down.

@cbracken cbracken closed this Jul 23, 2019
@cbracken
cbracken deleted the glfw-install branch August 1, 2019 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants