Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Explain why OpacityLayer has an offset field#9713

Merged
liyuqian merged 2 commits into
flutter-team-archive:masterfrom
liyuqian:opacity_offset_doc
Jul 8, 2019
Merged

Explain why OpacityLayer has an offset field#9713
liyuqian merged 2 commits into
flutter-team-archive:masterfrom
liyuqian:opacity_offset_doc

Conversation

@liyuqian

@liyuqian liyuqian commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

According to the request by Amir and Chris.

@amirh amirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo typos

//
// By default, that offset is always zero, and all the offsets are handled by
// some parent TransformLayers. But we allow the offset to be non-zero for
// backward compatibility. If it's non-zero, the old behavior is to propage

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo - propagate

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

@cyanglaz cyanglaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liyuqian liyuqian merged commit eb89d9d into flutter-team-archive:master Jul 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2019
@liyuqian liyuqian deleted the opacity_offset_doc branch August 14, 2019 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants