This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace arraysize macro with fml::size function#8975
Merged
Conversation
This is forward compatible with std::size and similar to how Chromium removed use of the arraysize macro.
mdempsky
changed the title
Contributor
Author
|
/cc @chinmaygarde |
chinmaygarde
approved these changes
May 15, 2019
Contributor
|
Are you able to merge? |
Contributor
Author
|
@chinmaygarde I don't believe so. I only see "Close and comment" and "Comment." |
Contributor
|
I'll merge this one. But, if you follow the guidance in the "Getting Started" section in go/flutter-onboarding, you should be added to the Flutter GitHub organization. |
Contributor
Author
|
@chinmaygarde Thanks, didn't know about that doc. Will do. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 15, 2019
…-archive/engine#8975) (#32771) flutter-team-archive/engine@ce22829...3cdfa80 git log ce22829..3cdfa80 --no-merges --oneline 3cdfa80 Replace ararysize macro with fml::size function (flutter-team-archive/engine#8975) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
…#8975) This is forward compatible with std::size and similar to how Chromium removed use of the arraysize macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is forward compatible with std::size and similar to how Chromium
removed use of the arraysize macro.