This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Android Embedding PR 16: Add touch support to FlutterView.#8034
Merged
Conversation
mklim
approved these changes
Mar 6, 2019
mklim
left a comment
mklim
left a comment
Contributor
There was a problem hiding this comment.
Java style LGTM pending one nit.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 9, 2019
flutter-team-archive/engine@c48774c...03d5f3c git log c48774c..03d5f3c --no-merges --oneline 03d5f3c Clarify arguments to FlutterEngineOnVsync (flutter-team-archive/engine#8093) 718329c Android Embedding PR 17: Clarify AccessibilityBridge and move logic out of FlutterView. (flutter-team-archive/engine#8061) edfc0cf Android Embedding PR 16: Add touch support to FlutterView. (flutter-team-archive/engine#8034) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android Embedding PR 16: Add touch support to FlutterView.
My test app now registers touch events as expected.