Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Android Embedding PR15: Add Viewport Metrics to FlutterView#8029

Merged
matthew-carroll merged 3 commits into
flutter-team-archive:masterfrom
matthew-carroll:android_embedding_refactor_pr15_add_viewport_metrics_to_flutterview
Mar 5, 2019
Merged

Android Embedding PR15: Add Viewport Metrics to FlutterView#8029
matthew-carroll merged 3 commits into
flutter-team-archive:masterfrom
matthew-carroll:android_embedding_refactor_pr15_add_viewport_metrics_to_flutterview

Conversation

@matthew-carroll

Copy link
Copy Markdown
Contributor

Android Embedding PR15: Add Viewport Metrics to FlutterView

@mklim mklim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java style LGTM

@jason-simmons jason-simmons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java Outdated
@matthew-carroll matthew-carroll merged commit fb3e35d into flutter-team-archive:master Mar 5, 2019
cbracken added a commit to cbracken/flutter that referenced this pull request Mar 5, 2019
flutter-team-archive/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter-team-archive/engine#8043)
flutter-team-archive/engine@effee2f80 remove extra statement (flutter-team-archive/engine#8041)
flutter-team-archive/engine@14e082fa0 (master) add lint script for Android with baseline (flutter-team-archive/engine#8036)
flutter-team-archive/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter-team-archive/engine#8040)
flutter-team-archive/engine@e6a5201f0 Add missing values to semantics action enums (flutter-team-archive/engine#8033)
flutter-team-archive/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter-team-archive/engine#8039)
flutter-team-archive/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter-team-archive/engine#8037)
flutter-team-archive/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter-team-archive/engine#8030)
flutter-team-archive/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter-team-archive/engine#8035)
flutter-team-archive/engine@2cd9b41ba Select MPL instead of LGPL (flutter-team-archive/engine#7991)
flutter-team-archive/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits)
flutter-team-archive/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter-team-archive/engine#8000)
flutter-team-archive/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter-team-archive/engine#8029)
flutter-team-archive/engine@36ca5740c (flutter-team-archive/engine#8026)
flutter-team-archive/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter-team-archive/engine#8028)
flutter-team-archive/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits)
flutter-team-archive/engine@a2246c199 Start of linting Android embedding (flutter-team-archive/engine#8023)
flutter-team-archive/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter-team-archive/engine#8024)
cbracken added a commit to flutter/flutter that referenced this pull request Mar 6, 2019
flutter-team-archive/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter-team-archive/engine#8043)
flutter-team-archive/engine@effee2f80 remove extra statement (flutter-team-archive/engine#8041)
flutter-team-archive/engine@14e082fa0 (master) add lint script for Android with baseline (flutter-team-archive/engine#8036)
flutter-team-archive/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter-team-archive/engine#8040)
flutter-team-archive/engine@e6a5201f0 Add missing values to semantics action enums (flutter-team-archive/engine#8033)
flutter-team-archive/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter-team-archive/engine#8039)
flutter-team-archive/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter-team-archive/engine#8037)
flutter-team-archive/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter-team-archive/engine#8030)
flutter-team-archive/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter-team-archive/engine#8035)
flutter-team-archive/engine@2cd9b41ba Select MPL instead of LGPL (flutter-team-archive/engine#7991)
flutter-team-archive/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits)
flutter-team-archive/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter-team-archive/engine#8000)
flutter-team-archive/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter-team-archive/engine#8029)
flutter-team-archive/engine@36ca5740c (flutter-team-archive/engine#8026)
flutter-team-archive/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter-team-archive/engine#8028)
flutter-team-archive/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits)
flutter-team-archive/engine@a2246c199 Start of linting Android embedding (flutter-team-archive/engine#8023)
flutter-team-archive/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter-team-archive/engine#8024)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants