This repository was archived by the owner on Feb 25, 2025. It is now read-only.
libtxt: truncate paragraph width to an integer in order to match Blink's behavior#5962
Merged
jason-simmons merged 1 commit intoAug 7, 2018
Merged
Conversation
Contributor
Author
chinmaygarde
approved these changes
Aug 7, 2018
amirh
approved these changes
Aug 7, 2018
amirh
left a comment
amirh
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the f2f explanation!
Maybe add some explanation to the PR as well?
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Aug 7, 2018
b3e866e Call drawPath without clip if possible (flutter-team-archive/engine#5952) 7e0bb3b Allow freezing a texture. (flutter-team-archive/engine#5938) 3cbb5e2 Persist DartCallbackCache contents across launches (flutter-team-archive/engine#5947) 953570a libtxt: truncate paragraph width to an integer in order to match Blink's behavior (flutter-team-archive/engine#5962)
Contributor
|
I don't think we should do this. It seems like it'll result in all kinds of weird effects. For example, suppose you're rendering text at font size 0.1 because you're in a very big scale transform or some such. |
Contributor
Author
|
This change matches the layout behavior that Flutter historically had with the Blink text renderer. I can try reverting this along with removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See flutter/flutter#18665