Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove C++ style from keyboard code#54883

Closed
robert-ancell wants to merge 3 commits into
flutter-team-archive:mainfrom
robert-ancell:keyboard-remove-cpp
Closed

Remove C++ style from keyboard code#54883
robert-ancell wants to merge 3 commits into
flutter-team-archive:mainfrom
robert-ancell:keyboard-remove-cpp

Conversation

@robert-ancell

Copy link
Copy Markdown
Contributor

It doesn't match the other GObject code and makes it harder to debug.

@cbracken cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asan sadness:

=================================================================
==315302==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete []) on 0x50200000a570
    #0 0x56115097b33d in operator delete[](void*) ../../../../../../llvm-llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:155:3
    #1 0x561150b823da in std::_fl::default_delete<char []>::_EnableIfConvertible<char>::type std::_fl::default_delete<char []>::operator()[abi:v15000]<char>(char*) const out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/__memory/unique_ptr.h:76:5
    #2 0x561150b823a7 in std::_fl::unique_ptr<char [], std::_fl::default_delete<char []>>::reset[abi:v15000](std::nullptr_t) out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/__memory/unique_ptr.h:537:7
    #3 0x561150b82308 in std::_fl::unique_ptr<char [], std::_fl::default_delete<char []>>::~unique_ptr[abi:v15000]() out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/__memory/unique_ptr.h:481:19
    #4 0x561150b4ddfc in (anonymous namespace)::CallRecord::~CallRecord() out/ci/host_debug_unopt/../../../flutter/shell/platform/linux/fl_keyboard_handler_test.cc:80:9
    #5 0x561150b4ff98 in std::_fl::allocator<(anonymous namespace)::CallRecord>::destroy[abi:v15000]((anonymous namespace)::CallRecord*) out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/__memory/allocator.h:170:15
    #6 0x561150b4ff6c in void std::_fl::allocator_traits<std::_fl::allocator<(anonymous namespace)::CallRecord>>::destroy[abi:v15000]<(anonymous namespace)::CallRecord, void>(std::_fl::allocator<(anonymous namespace)::CallRecord>&, (anonymous namespace)::CallRecord*) out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/__memory/allocator_traits.h:309:13
    #7 0x561150b53a9c in std::_fl::vector<(anonymous namespace)::CallRecord, std::_fl::allocator<(anonymous namespace)::CallRecord>>::__base_destruct_at_end[abi:v15000]((anonymous namespace)::CallRecord*) out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/vector:820:9
    #8 0x561150b53a19 in std::_fl::vector<(anonymous namespace)::CallRecord, std::_fl::allocator<(anonymous namespace)::CallRecord>>::__clear[abi:v15000]() out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/vector:814:29
    #9 0x561150b45e66 in std::_fl::vector<(anonymous namespace)::CallRecord, std::_fl::allocator<(anonymous namespace)::CallRecord>>::~vector[abi:v15000]() out/ci/host_debug_unopt/../../../flutter/third_party/libcxx/include/vector:429:9
    #10 0x561150b4501a in (anonymous namespace)::FlKeyboardHandlerTest_DisposeWithUnresolvedPends_Test::TestBody() out/ci/host_debug_unopt/../../../flutter/shell/platform/linux/fl_keyboard_handler_test.cc:597:1

@robert-ancell
robert-ancell marked this pull request as draft September 17, 2024 04:38
@flutter-dashboard

Copy link
Copy Markdown

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@robert-ancell

Copy link
Copy Markdown
Contributor Author

Closing this, replaced by #55601

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants