This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update gni filegroup when building Skia's codec files#54588
Merged
Conversation
kjlubick
changed the title
zanderso
approved these changes
Aug 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 19, 2024
flutter-team-archive/engine@52621de...e29b552 2024-08-19 kjlubick@users.noreply.github.com Update gni filegroup when building Skia's codec files (flutter-team-archive/engine#54588) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Aug 19, 2024
Follow-up to http://review.skia.org/890319 Client CLs: - https://crrev.com/c/5792163 - flutter-team-archive/engine#54588 Bug: chromium:356874896 Change-Id: I5056bd50b46261cc9b294f62d65215f05d68c89e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/891146 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Auto-Submit: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
) flutter-team-archive/engine@52621de...e29b552 2024-08-19 kjlubick@users.noreply.github.com Update gni filegroup when building Skia's codec files (flutter-team-archive/engine#54588) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in https://skia-review.googlesource.com/c/skia/+/890319 and Skia plans to delete the old group.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.