This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update Skia's BUILD.gn#52194
Merged
Merged
Conversation
brianosman
approved these changes
Apr 17, 2024
Remove references to `SkFontMgr_indirect` and `SkFontMgrRemotable`. These are not used by Flutter and Skia is removing them.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2024
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2024
flutter-team-archive/engine@376c86e...cc73c5c 2024-04-17 34871572+gmackall@users.noreply.github.com Replace LinkedLists that are used as a queue in android FlutterRenderer with ArrayDeques (flutter-team-archive/engine#51494) 2024-04-17 bdero@google.com [Impeller] Use booleans instead of counting backdrop reads. (flutter-team-archive/engine#52181) 2024-04-17 bungeman@chromium.org Update Skia's BUILD.gn (flutter-team-archive/engine#52194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…6940) flutter-team-archive/engine@376c86e...cc73c5c 2024-04-17 34871572+gmackall@users.noreply.github.com Replace LinkedLists that are used as a queue in android FlutterRenderer with ArrayDeques (flutter-team-archive/engine#51494) 2024-04-17 bdero@google.com [Impeller] Use booleans instead of counting backdrop reads. (flutter-team-archive/engine#52181) 2024-04-17 bungeman@chromium.org Update Skia's BUILD.gn (flutter-team-archive/engine#52194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to
SkFontMgr_indirectandSkFontMgrRemotable. These are not used by Flutter and Skia is removing them.