This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia from f7e3a5395fe1 to a1c58c4eb6d5 (2 revisions)#50609
Closed
Conversation
https://skia.googlesource.com/skia.git/+log/f7e3a5395fe1..a1c58c4eb6d5 2024-02-13 weiyuhuang@google.com Fix Half Leading for Strut. 2024-02-13 kjlubick@google.com Define GR_TEST_UTILS when building skqp for Android Framework If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-038f6d3d-cc85-4f43-99b9-7513259cd1d7-1707855217
branch
from
February 13, 2024 20:13
981f089 to
20d6d8a
Compare
skia-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Feb 13, 2024
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/50609, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Commit queue failed; closing this roll. |
8 tasks
auto-submit Bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
#50617) The previous skia roll (#50609) failed on [Linux linux_web_engine](https://ci.chromium.org/b/8756177705618610401). I've tested that the failing `canvaskit_api_tt_on_test.dart` would pass with the new skia revision `'a1c58c4eb6d5ae553097c5d27c134e09c8825e06` on this patch. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-038f6d3d-cc85-4f43-99b9-7513259cd1d7-1707855217
branch
February 20, 2024 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/f7e3a5395fe1..a1c58c4eb6d5
2024-02-13 weiyuhuang@google.com Fix Half Leading for Strut.
2024-02-13 kjlubick@google.com Define GR_TEST_UTILS when building skqp for Android Framework
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md