Roll ../src/third_party/skia/ abf7b763e..b33feaca1 (173 commits)

[skia-flutter-autoroll]

No description provided.

[rmistry]

@brianosman @Hixie @chinmaygarde This roll was created using the framework in skbug.com/7730 and should be ready to merge. Let @rmistry know if there are any problems.

[rmistry]

Could you please merge as well? (I am not a contributor)

[chinmaygarde]

Thanks. I’ll add you as a contributor as well.

[rmistry]

Thanks! I could approve the changes in #4915 but when I tried to merge but it said "Only those with write access to this repository can merge pull requests."

[aam]

This PR introduced an error that was flagged by flutter engine license check. And third_party license fingerprint was updated without fixing this error leaving surprise for unexpected. I just hit it as I was trying to roll dart and license verification check failed for my PR(https://travis-ci.org/flutter/engine/builds/364694215?utm_source=github_status&utm_medium=notification).

Manually synching to d653be8 and rerunning license check script shows that:

~/projects/flutter/test_root6/flutter/engine/src/flutter/tools/licenses  ‹d653be87f*› 
╰─➤  $FH/engine/src/out/host_debug_unopt/dart-sdk/bin/dart lib/main.dart --src ../../.. --out ../../../out/license_script_output --golden ../../travis/licenses_golden
Finding files...
Collecting licenses for flutter
      1224 of 1224 ██████████ 100% (0 missing licenses)  Done.                                                  
Collecting licenses for garnet
       541 of 541 ██████████ 100% (0 missing licenses)  Done.                                                
Collecting licenses for third_party
      7299 of 9333 ███████░░░ 78% (0 missing licenses)  .../Perf-Ubuntu17-GCC-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind_AbandonGpuContext_SK_CPU_LIMIT_SSE41      7302 of 9333 ███████░░░ 78% (0 missing licenses)  .../Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Release-All-Vulkan.json                                   9255 of 9333 █████████░ 99% (0 missing licenses)  .../../third_party/skia/src/xps/SkXPSDocument.cpperror searching for copyright in: ../../../third_party/skia/third_party/freetype2/include/freetype-android/ftmodule.h
file has no detectable license and no in-scope default license file


error searching for copyright in: ../../../third_party/skia/third_party/freetype2/include/freetype-android/ftoption.h
failed to find accompanying "LICENSE.TXT" in ../../../third_party/skia/third_party/freetype2/include/freetype-android
block:
---
/*  Copyright 1996-2018 by                                                 */
/*  David Turner, Robert Wilhelm, and Werner Lemberg.                      */
/*                                                                         */
/*  This file is part of the FreeType project, and may only be used,       */
/*  modified, and distributed under the terms of the FreeType project      */
/*  license, LICENSE.TXT.  By continuing to use, modify, or distribute     */
/*  this file you indicate that you have read the license and              */
/*  understand and accept it fully.
---


      9333 of 9333 ██████████ 100% (2 missing licenses)  Done.                                                     
Collecting licenses for topaz
    Skipping this component - no change in signature

cc @Hixie @alexmarkov

[rmistry]

Sorry about that! I think you have a few fixes for this in #4960

We are still working on trying to figure out the exact set of commands the auto-roller should be running and when it should be failing.
Ian added a comment here as well: #4959 (comment)

[aam]

Sure, no worries! Too bad I saw discussion about this on #4959 after investigated same failure in my #4960.
It is rather complicated setup, so issues are expected especially if you are trying to auto-roll(which is really awesome goal). Hopefully we can learn from all the mistakes if(when) we try to auto-roll dart. :-)